Bug 178372

Summary: No nightlies listed on nightly.webkit.org when using shipping Safari on macOS Sierra and OS X El Capitan
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit WebsiteAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jond, lforschler, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
URL: https://webkit.org/build-archives/
Attachments:
Description Flags
Patch thorton: review+

Daniel Bates
Reported 2017-10-16 20:07:48 PDT
Using shipping Safari version 10.1 (12603.1.24) on macOS Sierra (16E158), visit http://nightly.webkit.org. No nightlies are listed. The following JavaScript error is in the console: [Error] TypeError: timestamp of creationTimeNodes is not a function. (In 'timestamp of creationTimeNodes', 'timestamp of creationTimeNodes' is undefined) (anonymous function) (build-archives:81)
Attachments
Patch (2.54 KB, patch)
2017-10-16 20:19 PDT, Daniel Bates 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-10-16 20:08:16 PDT
nightly.webkit.org redirects to https://webkit.org/build-archives/.
Daniel Bates
Comment 2 2017-10-16 20:10:13 PDT
The WebKit Build Archives pages depends on collections being iterable.
Daniel Bates
Comment 3 2017-10-16 20:12:08 PDT
(In reply to Daniel Bates from comment #2) > The WebKit Build Archives pages depends on collections being iterable. Clearly, such support is not included in shipping Safari on macOS Sierra and OS X El Capitan. So long as we are keeping nightlies for macOS Sierra and OS X El Capitan we should make the WebKit Build Archive page work when using shipping Safari on this OSes.
Daniel Bates
Comment 4 2017-10-16 20:19:51 PDT
Created attachment 323979 [details] Patch
Daniel Bates
Comment 5 2017-10-16 20:26:45 PDT
Committed r223455: <https://trac.webkit.org/changeset/223455>
Radar WebKit Bug Importer
Comment 6 2017-10-16 20:27:40 PDT
<rdar://problem/35021863>
Alexey Proskuryakov
Comment 7 2017-10-16 23:00:39 PDT
Nightlies are only supported to work with Safari 11 at this point. Just wanted to point this out for completeness, it seems good to make the page work in old browsers too regardless.
Note You need to log in before you can comment on or make changes to this bug.