Summary: | Add and remove cookie partition accordingly in intermediary redirect requests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||||
Component: | WebKit2 | Assignee: | John Wilander <wilander> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, rniwa, webkit-bug-importer, wilander | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
John Wilander
2017-10-16 17:12:14 PDT
Created attachment 323961 [details]
Patch
Attachment 323961 [details] did not pass style-queue:
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:202: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The style error is due to deliberate aligning in the comment on rules for when to switch partition. Comment on attachment 323961 [details] Patch Attachment 323961 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4876879 New failing tests: http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html Created attachment 323969 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 323976 [details]
Patch
Test failure on El Cap since cookie partitioning is not supported there. Changed test expectations to only enable the new tests on iOS and macOS High Sierra. Attachment 323976 [details] did not pass style-queue:
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:202: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 323976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323976&action=review Looks good. Please correct the minor style issues I mentioned before landing. > Source/WebCore/ChangeLog:14 > + by the TestRunner. You should mention that you removed an unimplemented method declaration (for completeness). > Source/WebCore/loader/ResourceLoadObserver.h:-56 > - WEBCORE_EXPORT void setShouldThrottleObserverNotifications(bool); I wish the compiler warned about declarations with no implementations. > LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html:5 > + <script src="../../resources/js-test-pre.js"></script> Can this just be "js-test.js"? > LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html:10 > + I think we prefer to do: jsTestIsAsync = true; nowadays. > LayoutTests/http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html:102 > + testRunner.notifyDone(); I think this should be finishJSTest();. Created attachment 324031 [details]
Patch for landing
Thanks for the review, Brent! All comments addressed. Comment on attachment 324031 [details] Patch for landing Clearing flags on attachment: 324031 Committed r223565: <https://trac.webkit.org/changeset/223565> All reviewed patches have been landed. Closing bug. |