Bug 178351

Summary: Add a _WKThumbnailView initializer with a WKWebView
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-10-16 11:14:24 PDT
Add a _WKThumbnailView initializer with a WKWebView
Attachments
Patch (7.07 KB, patch)
2017-10-16 11:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2017-10-16 14:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-16 11:15:22 PDT
Created attachment 323912 [details] Patch
Tim Horton
Comment 2 2017-10-16 13:53:03 PDT
Comment on attachment 323912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323912&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:86 > +- (instancetype)initWithFrame:(NSRect)frame fromWKWebView:(WKWebView *)webView I would also override initWithFrame, put the common things in there, and call self instead of super in each of these, to reduce duplication. > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:141 > + if (_wkView) { This would all be muuuuuch neater with a WKThumbnailableView (or WKThumbnailViewDelegate, or...) protocol.
Alex Christensen
Comment 3 2017-10-16 14:32:51 PDT
Created attachment 323942 [details] Patch
Alex Christensen
Comment 4 2017-10-16 14:33:33 PDT
http://trac.webkit.org/r223439
Alex Christensen
Comment 5 2017-10-16 14:34:20 PDT
> This would all be muuuuuch neater with a WKThumbnailableView (or > WKThumbnailViewDelegate, or...) protocol. I agree. I think it would be even cleaner if we just quickly got rid of the uses of WKView.
Radar WebKit Bug Importer
Comment 6 2017-10-16 14:34:29 PDT
<rdar://problem/35015188>
Note You need to log in before you can comment on or make changes to this bug.