| Summary: | Add a _WKThumbnailView initializer with a WKWebView | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2017-10-16 11:14:24 PDT
Created attachment 323912 [details]
Patch
Comment on attachment 323912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323912&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:86 > +- (instancetype)initWithFrame:(NSRect)frame fromWKWebView:(WKWebView *)webView I would also override initWithFrame, put the common things in there, and call self instead of super in each of these, to reduce duplication. > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:141 > + if (_wkView) { This would all be muuuuuch neater with a WKThumbnailableView (or WKThumbnailViewDelegate, or...) protocol. Created attachment 323942 [details]
Patch
> This would all be muuuuuch neater with a WKThumbnailableView (or
> WKThumbnailViewDelegate, or...) protocol.
I agree. I think it would be even cleaner if we just quickly got rid of the uses of WKView.
|