Summary: | REGRESSION(223307): ASSERTION FAILED: document.page() in WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution(WebCore::Document const&) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, cdumez, jlewis3, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2017-10-16 09:14:50 PDT
This started with https://trac.webkit.org/changeset/223307/webkit. Brent, do the tests need to be updated? (In reply to Ryan Haddad from comment #1) > This started with https://trac.webkit.org/changeset/223307/webkit. > > Brent, do the tests need to be updated? No, but I think this assertion isn't quite right. I'll fix this to get the bots green. In Bug 178183 I made a mistake in the topDocument to use for logging user interaction. I was using 'topDocument->topDocument()', which I should have been using 'm_frame.document()->topDocument()'. Created attachment 323904 [details]
Patch
Comment on attachment 323904 [details]
Patch
r=me
(In reply to Chris Dumez from comment #6) > Comment on attachment 323904 [details] > Patch > > r=me I'll obviously fix my lack of an "address-of" operator before landing. :-\ Committed r223418: <https://trac.webkit.org/changeset/223418> |