| Summary: | [JSC] ScriptFetcher should be notified directly from module pipeline | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||
| Status: | REOPENED --- | ||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, dbates, esprehn+autocc, jlewis3, kangil.han, keith_miller, mark.lam, msaboff, rniwa, saam, sam | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 178594 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Yusuke Suzuki
2017-10-16 07:35:34 PDT
Created attachment 324224 [details]
Patch
Comment on attachment 324224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324224&action=review > Source/JavaScriptCore/runtime/JSModuleLoader.cpp:312 > + Identifier moduleKey = jsValueToModuleKey(exec, key); could use auto here. Comment on attachment 324224 [details] Patch Attachment 324224 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4919473 New failing tests: http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect.html js/dom/modules/module-execution-error-should-be-propagated-to-onerror.html http/tests/security/module-no-mime-type.html Created attachment 324231 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324224 [details] Patch Attachment 324224 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4919564 New failing tests: http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect.html js/dom/modules/module-execution-error-should-be-propagated-to-onerror.html http/tests/security/module-no-mime-type.html Created attachment 324234 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 324224 [details] Patch Attachment 324224 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4919579 New failing tests: http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect.html js/dom/modules/module-execution-error-should-be-propagated-to-onerror.html http/tests/security/module-no-mime-type.html Created attachment 324235 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324224 [details] Patch Attachment 324224 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4923102 New failing tests: http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect.html js/dom/modules/module-execution-error-should-be-propagated-to-onerror.html http/tests/security/module-no-mime-type.html Created attachment 324291 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Committed r223744: <https://trac.webkit.org/changeset/223744> Committed r223750: <https://trac.webkit.org/changeset/223750> Committed r223751: <https://trac.webkit.org/changeset/223751> These patches have caused several existing and newly added test to fail consistently:
http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect.html
http/tests/security/module-no-mime-type.html
js/dom/modules/import-from-javascript-url.html
History (in same order):
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2F1.1%2Fmodule-scriptnonce-redirect.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fmodule-no-mime-type.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fmodules%2Fimport-from-javascript-url.html
build:
https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r223757%20(433)/results.html
Re-opened since this is blocked by bug 178594 |