Bug 178330

Summary: [Settings] Remove all custom code from Settings.h/cpp
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+, commit-queue: commit-queue-

Sam Weinig
Reported 2017-10-15 20:55:46 PDT
[Settings] Remove all custom code from Settings.h/cpp
Attachments
Patch (9.03 KB, patch)
2017-10-15 20:58 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.99 KB, patch)
2017-10-15 21:02 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.63 KB, patch)
2017-10-15 21:20 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (23.67 KB, patch)
2017-10-16 03:20 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (29.11 KB, patch)
2017-10-16 03:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (29.17 KB, patch)
2017-10-16 08:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (29.26 KB, patch)
2017-10-16 08:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (30.40 KB, patch)
2017-10-16 08:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (31.07 KB, patch)
2017-10-16 10:57 PDT, Sam Weinig 		simon.fraser: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-15 20:58:29 PDT
Created attachment 323868 [details] Patch
Sam Weinig
Comment 2 2017-10-15 21:02:41 PDT
Created attachment 323869 [details] Patch
Sam Weinig
Comment 3 2017-10-15 21:20:59 PDT
Created attachment 323871 [details] Patch
Sam Weinig
Comment 4 2017-10-16 03:20:02 PDT
Created attachment 323882 [details] Patch
Sam Weinig
Comment 5 2017-10-16 03:34:40 PDT
Created attachment 323884 [details] Patch
Sam Weinig
Comment 6 2017-10-16 08:15:53 PDT
Created attachment 323895 [details] Patch
Sam Weinig
Comment 7 2017-10-16 08:36:11 PDT
Created attachment 323896 [details] Patch
Sam Weinig
Comment 8 2017-10-16 08:38:30 PDT
Created attachment 323897 [details] Patch
Sam Weinig
Comment 9 2017-10-16 10:57:26 PDT
Created attachment 323907 [details] Patch
WebKit Commit Bot
Comment 10 2017-10-16 13:12:36 PDT
Comment on attachment 323907 [details] Patch Rejecting attachment 323907 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 323907, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/4873915
Sam Weinig
Comment 11 2017-10-16 13:33:34 PDT
Committed r223432: <https://trac.webkit.org/changeset/223432>
Radar WebKit Bug Importer
Comment 12 2017-10-16 13:34:29 PDT
<rdar://problem/35013435>
Note You need to log in before you can comment on or make changes to this bug.