Bug 178330

Summary: [Settings] Remove all custom code from Settings.h/cpp
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+, commit-queue: commit-queue-

Description Sam Weinig 2017-10-15 20:55:46 PDT
[Settings] Remove all custom code from Settings.h/cpp
Comment 1 Sam Weinig 2017-10-15 20:58:29 PDT
Created attachment 323868 [details]
Patch
Comment 2 Sam Weinig 2017-10-15 21:02:41 PDT
Created attachment 323869 [details]
Patch
Comment 3 Sam Weinig 2017-10-15 21:20:59 PDT
Created attachment 323871 [details]
Patch
Comment 4 Sam Weinig 2017-10-16 03:20:02 PDT
Created attachment 323882 [details]
Patch
Comment 5 Sam Weinig 2017-10-16 03:34:40 PDT
Created attachment 323884 [details]
Patch
Comment 6 Sam Weinig 2017-10-16 08:15:53 PDT
Created attachment 323895 [details]
Patch
Comment 7 Sam Weinig 2017-10-16 08:36:11 PDT
Created attachment 323896 [details]
Patch
Comment 8 Sam Weinig 2017-10-16 08:38:30 PDT
Created attachment 323897 [details]
Patch
Comment 9 Sam Weinig 2017-10-16 10:57:26 PDT
Created attachment 323907 [details]
Patch
Comment 10 WebKit Commit Bot 2017-10-16 13:12:36 PDT
Comment on attachment 323907 [details]
Patch

Rejecting attachment 323907 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 323907, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4873915
Comment 11 Sam Weinig 2017-10-16 13:33:34 PDT
Committed r223432: <https://trac.webkit.org/changeset/223432>
Comment 12 Radar WebKit Bug Importer 2017-10-16 13:34:29 PDT
<rdar://problem/35013435>