Bug 178234

Summary:

import-w3c-tests modifies test sources and sometimes causes them to fail

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, darin, lforschler, rniwa, ryanhaddad, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none

Description Chris Dumez 2017-10-12 14:46:17 PDT

One of the checks for http://w3c-test.org/dom/nodes/MutationObserver-characterData.html is failing in our layout tests because the test importer has modified spacing in one of the HTML comments. The unmodified version of the test passes in WebKit.

Comment 1 Chris Dumez 2017-10-12 15:17:41 PDT

Created attachment 323578 [details]
WIP Patch

Comment 2 Chris Dumez 2017-10-12 15:24:56 PDT

Created attachment 323581 [details]
WIP Patch

Comment 3 Build Bot 2017-10-12 15:30:05 PDT

Attachment 323581 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:436:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 717 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Chris Dumez 2017-10-12 15:39:51 PDT

Created attachment 323582 [details]
Patch

Comment 5 Chris Dumez 2017-10-12 16:11:42 PDT

Created attachment 323589 [details]
Patch

Comment 6 Chris Dumez 2017-10-12 19:04:45 PDT

Comment on attachment 323589 [details]
Patch

Clearing flags on attachment: 323589

Committed r223273: <https://trac.webkit.org/changeset/223273>

Comment 7 Chris Dumez 2017-10-12 19:04:47 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2017-10-12 19:05:17 PDT

<rdar://problem/34969196>

Comment 9 Ryan Haddad 2017-10-13 09:33:10 PDT

This change introduced a webkitpy test failure:
[1618/1654] webkitpy.w3c.test_importer_unittest.TestImporterTest.test_harnesslinks_conversion failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/sierra-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py", line 162, in test_harnesslinks_conversion
      self.assertTrue('src="../' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/csswg-tests/t/test.html'))
  AssertionError: False is not true
  
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/4998/steps/webkitpy-test/logs/stdio

Comment 10 Chris Dumez 2017-10-13 10:06:02 PDT

(In reply to Ryan Haddad from comment #9)
> This change introduced a webkitpy test failure:
> [1618/1654]
> webkitpy.w3c.test_importer_unittest.TestImporterTest.
> test_harnesslinks_conversion failed:
>   Traceback (most recent call last):
>     File
> "/Volumes/Data/slave/sierra-release-tests-wk2/build/Tools/Scripts/webkitpy/
> w3c/test_importer_unittest.py", line 162, in test_harnesslinks_conversion
>       self.assertTrue('src="../' in
> fs.read_text_file('/mock-checkout/LayoutTests/w3c/csswg-tests/t/test.html'))
>   AssertionError: False is not true
>   
> https://build.webkit.org/builders/
> Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/4998/steps/webkitpy-test/
> logs/stdio

Should be addressed in <https://trac.webkit.org/changeset/223281>.