Bug 178229

Summary:

Change WebCore sources to work with unified source builds

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, mitz, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=178424

Bug Depends on:

Bug Blocks:

177996

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch	none
Patch	none
Patch	none
Patch	none

Keith Miller

Reported 2017-10-12 13:46:58 PDT

Change WebCore sources to work with unified source builds

Attachments
Patch (473.57 KB, patch) 2017-10-12 13:52 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (503.12 KB, patch) 2017-10-12 14:09 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (476.44 KB, patch) 2017-10-12 14:39 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (478.08 KB, patch) 2017-10-12 15:24 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (477.66 KB, patch) 2017-10-12 16:31 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (478.20 KB, patch) 2017-10-16 12:25 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (478.83 KB, patch) 2017-10-16 15:14 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (478.99 KB, patch) 2017-10-16 15:24 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (479.17 KB, patch) 2017-10-16 16:44 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (479.52 KB, patch) 2017-10-16 19:16 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (479.89 KB, patch) 2017-10-16 20:59 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-10-12 13:52:50 PDT

Created attachment 323559 [details] Patch

Build Bot

Comment 2 2017-10-12 13:55:12 PDT

Attachment 323559 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 407 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-10-12 13:55:55 PDT

Comment on attachment 323559 [details] Patch Attachment 323559 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4836403 New failing tests: (JS) JSTestCallbackFunction.cpp (JS) JSTestCallbackFunctionRethrow.cpp (JS) JSTestCallbackFunctionWithThisObject.cpp (JS) JSTestCallbackFunctionWithTypedefs.cpp (JS) JSTestCallbackInterface.cpp (JS) JSTestCallTracer.cpp (JS) JSTestCEReactions.cpp (JS) JSTestCEReactionsStringifier.cpp (JS) JSTestClassWithJSBuiltinConstructor.cpp (JS) JSTestCustomConstructorWithNoInterfaceObject.cpp (JS) JSTestActiveDOMObject.cpp (JS) JSTestDOMJIT.cpp (JS) JSTestEnabledBySetting.cpp (JS) JSTestEventConstructor.cpp (JS) JSTestEventTarget.cpp (JS) JSTestException.cpp (JS) JSTestGenerateIsReachable.cpp (JS) JSTestGlobalObject.cpp (JS) JSTestIndexedSetterNoIdentifier.cpp (JS) JSTestIndexedSetterThrowingException.cpp (JS) JSTestIndexedSetterWithIdentifier.cpp (JS) JSTestInterface.cpp (JS) JSTestInterfaceLeadingUnderscore.cpp (JS) JSTestIterable.cpp (JS) JSTestJSBuiltinConstructor.cpp (JS) JSMapLike.cpp (JS) JSTestMediaQueryListListener.cpp (JS) JSTestNamedAndIndexedSetterNoIdentifier.cpp (JS) JSTestNamedAndIndexedSetterThrowingException.cpp (JS) JSTestNamedAndIndexedSetterWithIdentifier.cpp (JS) JSTestNamedConstructor.cpp (JS) JSTestNamedDeleterNoIdentifier.cpp (JS) JSTestNamedDeleterThrowingException.cpp (JS) JSTestNamedDeleterWithIdentifier.cpp (JS) JSTestNamedDeleterWithIndexedGetter.cpp (JS) JSTestNamedGetterCallWith.cpp (JS) JSTestNamedGetterNoIdentifier.cpp (JS) JSTestNamedGetterWithIdentifier.cpp (JS) JSTestNamedSetterNoIdentifier.cpp (JS) JSTestNamedSetterThrowingException.cpp (JS) JSTestNamedSetterWithIdentifier.cpp (JS) JSTestNamedSetterWithIndexedGetter.cpp (JS) JSTestNamedSetterWithIndexedGetterAndSetter.cpp (JS) JSTestNamedSetterWithOverrideBuiltins.cpp (JS) JSTestNamedSetterWithUnforgableProperties.cpp (JS) JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp (JS) JSTestNode.cpp (JS) JSTestObj.cpp (JS) JSTestOverloadedConstructors.cpp (JS) JSTestOverloadedConstructorsWithSequence.cpp (JS) JSTestOverrideBuiltins.cpp (JS) JSTestPluginInterface.cpp (JS) JSTestPromiseRejectionEvent.cpp (JS) JSReadOnlyMapLike.cpp (JS) JSInterfaceName.cpp (JS) JSTestSerialization.cpp (JS) JSTestSerializationIndirectInheritance.cpp (JS) JSTestSerializationInherit.cpp (JS) JSTestSerializationInheritFinal.cpp (JS) JSTestSerializedScriptValueInterface.cpp (JS) JSTestStandaloneDictionary.cpp (JS) JSTestStandaloneEnumeration.cpp (JS) JSTestStringifier.cpp (JS) JSTestStringifierAnonymousOperation.cpp (JS) JSTestStringifierNamedOperation.cpp (JS) JSTestStringifierOperationImplementedAs.cpp (JS) JSTestStringifierOperationNamedToString.cpp (JS) JSTestStringifierReadOnlyAttribute.cpp (JS) JSTestStringifierReadWriteAttribute.cpp (JS) JSTestTypedefs.cpp (JS) JSTestVoidCallbackFunction.cpp

Keith Miller

Comment 4 2017-10-12 14:09:29 PDT

Created attachment 323561 [details] Patch

Build Bot

Comment 5 2017-10-12 14:12:48 PDT

Attachment 323561 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 408 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2017-10-12 14:13:58 PDT

Comment on attachment 323561 [details] Patch Attachment 323561 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4836592 New failing tests: (JS) JSTestCallbackInterface.cpp

Keith Miller

Comment 7 2017-10-12 14:39:06 PDT

Created attachment 323565 [details] Patch

Build Bot

Comment 8 2017-10-12 14:43:16 PDT

Attachment 323565 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 407 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 9 2017-10-12 15:24:11 PDT

Created attachment 323580 [details] Patch

Build Bot

Comment 10 2017-10-12 15:28:52 PDT

Attachment 323580 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 407 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 11 2017-10-12 16:31:43 PDT

Created attachment 323598 [details] Patch

Build Bot

Comment 12 2017-10-12 16:35:26 PDT

Attachment 323598 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 406 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 13 2017-10-16 12:25:04 PDT

Created attachment 323928 [details] Patch

Build Bot

Comment 14 2017-10-16 12:29:31 PDT

Attachment 323928 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 405 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 15 2017-10-16 12:36:14 PDT

Comment on attachment 323928 [details] Patch rs=me

Keith Miller

Comment 16 2017-10-16 15:14:02 PDT

Created attachment 323946 [details] Patch for landing

Keith Miller

Comment 17 2017-10-16 15:15:12 PDT

Ugh, webkit-patch didn't see it was rubber stamped... :(

Keith Miller

Comment 18 2017-10-16 15:24:17 PDT

Created attachment 323947 [details] Patch

Build Bot

Comment 19 2017-10-16 16:27:04 PDT

Attachment 323947 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 49 in 405 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 20 2017-10-16 16:44:18 PDT

Created attachment 323956 [details] Patch

Build Bot

Comment 21 2017-10-16 16:46:25 PDT

Attachment 323956 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 50 in 406 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 22 2017-10-16 19:16:18 PDT

Created attachment 323972 [details] Patch

Build Bot

Comment 23 2017-10-16 19:18:28 PDT

Attachment 323972 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:56: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:77: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 51 in 406 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 24 2017-10-16 20:59:43 PDT

Created attachment 323986 [details] Patch

Build Bot

Comment 25 2017-10-16 21:03:44 PDT

Attachment 323986 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:108: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:198: CryptoAlgorithmRSA_OAEPInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:76: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:116: CryptoAlgorithmAES_KWInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:55: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/ScrollbarThemeMac.mm:50: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:51: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:119: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:160: CryptoAlgorithmAES_CTRInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:56: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:61: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:77: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:111: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:152: CryptoAlgorithmAES_CFBInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:64: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:55: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:75: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:108: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:159: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:200: CryptoAlgorithmAES_GCMInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:43: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:105: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:183: CryptoAlgorithmRSASSA_PKCS1_v1_5Internal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:106: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:184: CryptoAlgorithmRSA_PSSInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:71: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:61: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:77: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:111: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:152: CryptoAlgorithmAES_CBCInternal is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/ios/WebAVPlayerController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:157: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 50 in 407 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 26 2017-10-17 00:11:06 PDT

Comment on attachment 323986 [details] Patch Clearing flags on attachment: 323986 Committed r223476: <https://trac.webkit.org/changeset/223476>

WebKit Commit Bot

Comment 27 2017-10-17 00:11:08 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 28 2017-10-17 00:12:19 PDT

<rdar://problem/35024100>

mitz

Comment 29 2017-10-17 20:19:40 PDT

(In reply to WebKit Commit Bot from comment #26) > Comment on attachment 323986 [details] > Patch > > Clearing flags on attachment: 323986 > > Committed r223476: <https://trac.webkit.org/changeset/223476> This caused bug 178424.

mitz

Comment 30 2017-10-17 20:21:40 PDT

(In reply to mitz from comment #29) > (In reply to WebKit Commit Bot from comment #26) > > Comment on attachment 323986 [details] > > Patch > > > > Clearing flags on attachment: 323986 > > > > Committed r223476: <https://trac.webkit.org/changeset/223476> > > This caused bug 178424. Disappointingly, the change log entry for SoftLinking.h is empty, so it’s hard to tell what motivated the bad change.

Note You need to log in before you can comment on or make changes to this bug.