Bug 178161

Summary: createRenderer should call initializeStyle
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bfulgham, buildbot, rniwa, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
Archive of layout-test-results from ews126 for ios-simulator-wk2 none

Antti Koivisto
Reported 2017-10-11 03:15:09 PDT
Stop requiring a manual initializeStyle call after every createRenderer.
Attachments
patch (24.51 KB, patch)
2017-10-11 03:19 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (1.47 MB, application/zip)
2017-10-11 04:37 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.61 MB, application/zip)
2017-10-11 04:42 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.21 MB, application/zip)
2017-10-11 04:53 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.48 MB, application/zip)
2017-10-11 05:01 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-10-11 03:19:15 PDT
Created attachment 323401 [details] patch
Build Bot
Comment 2 2017-10-11 04:37:45 PDT
Comment on attachment 323401 [details] patch Attachment 323401 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4822794 New failing tests: scrollbars/scrollbar-orientation.html fast/dom/Element/scroll-width-hidden.html fast/block/float/marquee-shrink-to-avoid-floats.html fast/ruby/float-overhang-from-ruby-text.html fast/html/marquee-scrollamount.html scrollbars/scrollbar-buttons.html scrollbars/scrollbar-parts-opacity.html fast/dom/Element/scroll-width-visible.html scrollbars/overflow-scrollbar-combinations.html fast/ruby/assert-with-block-rt-child-and-emphasis.html fast/html/marquee-child-wrap.html
Build Bot
Comment 3 2017-10-11 04:37:46 PDT
Created attachment 323406 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-10-11 04:42:25 PDT
Comment on attachment 323401 [details] patch Attachment 323401 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4822817 New failing tests: scrollbars/scrollbar-orientation.html fast/dom/Element/scroll-width-hidden.html fast/dom/Element/scroll-width-visible.html fast/ruby/float-overhang-from-ruby-text.html scrollbars/scrollbar-buttons.html fast/inline-block/003.html scrollbars/scrollbar-parts-opacity.html fast/html/marquee-scrollamount.html scrollbars/overflow-scrollbar-combinations.html fast/block/float/marquee-shrink-to-avoid-floats.html fast/ruby/assert-with-block-rt-child-and-emphasis.html fast/html/marquee-child-wrap.html
Build Bot
Comment 5 2017-10-11 04:42:26 PDT
Created attachment 323407 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-10-11 04:53:12 PDT
Comment on attachment 323401 [details] patch Attachment 323401 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4822829 New failing tests: scrollbars/scrollbar-orientation.html fast/dom/Element/scroll-width-hidden.html fast/block/float/marquee-shrink-to-avoid-floats.html fast/ruby/float-overhang-from-ruby-text.html fast/html/marquee-scrollamount.html scrollbars/scrollbar-buttons.html scrollbars/scrollbar-parts-opacity.html fast/dom/Element/scroll-width-visible.html scrollbars/overflow-scrollbar-combinations.html fast/ruby/assert-with-block-rt-child-and-emphasis.html fast/html/marquee-child-wrap.html
Build Bot
Comment 7 2017-10-11 04:53:13 PDT
Created attachment 323408 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 8 2017-10-11 05:01:06 PDT
Comment on attachment 323401 [details] patch Attachment 323401 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4822873 New failing tests: scrollbars/scrollbar-orientation.html fast/dom/Element/scroll-width-hidden.html fast/dom/Element/scroll-width-visible.html fast/ruby/float-overhang-from-ruby-text.html fast/html/marquee-scrollamount.html scrollbars/scrollbar-buttons.html fast/inline-block/003.html scrollbars/scrollbar-parts-opacity.html fast/block/float/marquee-shrink-to-avoid-floats.html scrollbars/overflow-scrollbar-combinations.html fast/ruby/assert-with-block-rt-child-and-emphasis.html fast/html/marquee-child-wrap.html
Build Bot
Comment 9 2017-10-11 05:01:07 PDT
Created attachment 323409 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Note You need to log in before you can comment on or make changes to this bug.