Summary: | Fix compilation when MASM_PROBE (and therefore DFG) are disabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Guillaume Emont <guijemont> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Guillaume Emont
2017-10-10 10:29:59 PDT
Created attachment 323318 [details]
Patch
Patch fixing the issue.
Comment on attachment 323318 [details]
Patch
Informal review: r+
Comment on attachment 323318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323318&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2323 > +#if ENABLE(MASM_PROBE) This should be: #if ENABLE(DFGJIT) or whatever the correct ENABLE name is > Source/JavaScriptCore/bytecode/CodeBlock.h:80 > +#if ENABLE(MASM_PROBE) ditto > Source/JavaScriptCore/bytecode/CodeBlock.h:774 > +#if ENABLE(MASM_PROBE) > OptimizeAction updateOSRExitCounterAndCheckIfNeedToReoptimize(DFG::OSRExitState&); > +#endif ditto Created attachment 323351 [details]
Patch
New version using ENABLE(DFG_JIT)
Comment on attachment 323351 [details] Patch Clearing flags on attachment: 323351 Committed r223155: <http://trac.webkit.org/changeset/223155> All reviewed patches have been landed. Closing bug. |