Bug 178129

Summary:

Rebaseline tests at media/modern-media-controls/media-controller

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none

Antoine Quint

Reported 2017-10-10 05:50:36 PDT

Rebaseline tests at media/modern-media-controls/media-controller

Attachments
Patch (48.86 KB, patch) 2017-10-10 05:53 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.01 MB, application/zip) 2017-10-10 07:04 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.27 MB, application/zip) 2017-10-10 07:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (966.22 KB, application/zip) 2017-10-10 07:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.90 MB, application/zip) 2017-10-10 07:24 PDT, Build Bot	no flags	Details
Patch (61.05 KB, patch) 2017-10-11 05:24 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2017-10-10 05:53:16 PDT

Created attachment 323300 [details] Patch

Build Bot

Comment 2 2017-10-10 07:04:01 PDT

Comment on attachment 323300 [details] Patch Attachment 323300 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4811988 New failing tests: media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Build Bot

Comment 3 2017-10-10 07:04:02 PDT

Created attachment 323304 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-10 07:11:02 PDT

Comment on attachment 323300 [details] Patch Attachment 323300 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4812041 New failing tests: media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Build Bot

Comment 5 2017-10-10 07:11:03 PDT

Created attachment 323305 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-10-10 07:22:24 PDT

Comment on attachment 323300 [details] Patch Attachment 323300 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4812052 New failing tests: media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html

Build Bot

Comment 7 2017-10-10 07:22:25 PDT

Created attachment 323306 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 8 2017-10-10 07:24:57 PDT

Comment on attachment 323300 [details] Patch Attachment 323300 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4812053 New failing tests: media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Build Bot

Comment 9 2017-10-10 07:24:59 PDT

Created attachment 323307 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Dean Jackson

Comment 10 2017-10-10 11:00:20 PDT

Comment on attachment 323300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323300&action=review r+ assuming you fix all the EWS failures > LayoutTests/platform/mac/TestExpectations:1551 > +media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ] > +media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html [ Skip ] > +media/modern-media-controls/media-controller/media-controller-scale-factor.html [ Skip ] Maybe put iOS tests in a sub directory? > LayoutTests/platform/mac/TestExpectations:1562 > +# These tests are timing-related and can fail due to performance issues on bots > +media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ] > +media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ] > +media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html [ Pass Failure ] > +media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ] > +media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Failure ] You should add a comment to the bug to fix these.

Antoine Quint

Comment 11 2017-10-11 05:24:58 PDT

Created attachment 323411 [details] Patch

Antoine Quint

Comment 12 2017-10-11 05:26:49 PDT

(In reply to Dean Jackson from comment #10) > Comment on attachment 323300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323300&action=review > > r+ assuming you fix all the EWS failures > > > LayoutTests/platform/mac/TestExpectations:1551 > > +media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ] > > +media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html [ Skip ] > > +media/modern-media-controls/media-controller/media-controller-scale-factor.html [ Skip ] > > Maybe put iOS tests in a sub directory? Done in the latest patch. > > LayoutTests/platform/mac/TestExpectations:1562 > > +# These tests are timing-related and can fail due to performance issues on bots > > +media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ] > > +media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ] > > +media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html [ Pass Failure ] > > +media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ] > > +media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Failure ] > > You should add a comment to the bug to fix these. These cannot be fixed. By nature they will be flaky due to bots performance and accurate timing requirements. They are likely to pass the vast majority of the time, but fail sometimes. I'd rather keep them as [ Pass Failure ] than not have them at all, if they ever turn red consistently, I'd eventually catch it routinely looking at the flakiness dashboard for those tests.

Sam Weinig

Comment 13 2017-10-11 05:27:18 PDT

Comment on attachment 323411 [details] Patch rs=me when things pass.

Sam Weinig

Comment 14 2017-10-11 05:28:00 PDT

Oh, Dean already did that. Sorry.

Antoine Quint

Comment 15 2017-10-11 05:30:50 PDT

(In reply to Sam Weinig from comment #14) > Oh, Dean already did that. Sorry. Your rs carries much more weight than dino's r.

WebKit Commit Bot

Comment 16 2017-10-11 06:52:02 PDT

Comment on attachment 323411 [details] Patch Clearing flags on attachment: 323411 Committed r223176: <http://trac.webkit.org/changeset/223176>

WebKit Commit Bot

Comment 17 2017-10-11 06:52:04 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2017-10-11 06:53:05 PDT

<rdar://problem/34932465>

Note You need to log in before you can comment on or make changes to this bug.