Bug 178125

Summary: [WPE] Remove the possibility of installing the old WebKit2 C API
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WPE WebKitAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro, webkit-bug-importer, zan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 176475, 178100, 178104    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-10-10 04:26:45 PDT
We have the new GLib-based API, and we really don't want to maintain two different sets of public API.
Attachments
Patch (8.86 KB, patch)
2017-10-10 16:03 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-10-10 04:30:46 PDT
Updated dependency bugs. This shouldn't be removed until we ensure that the new GLib WPE API is usable.
Michael Catanzaro
Comment 2 2017-10-10 04:45:51 PDT
You can remove it now if you want; I'll be doing so at first opportunity in any case. We agreed that removing the C API and ensuring the GLib API works are both blockers for the first release and it doesn't matter which order that happens in.
Carlos Alberto Lopez Perez
Comment 3 2017-10-10 12:20:17 PDT
IIRC WPEWebKitLauncher doesn't build anymore with current trunk (even when enabling the deprecated headers). dyz is works fine for me as a replacement for WPEWebKitLauncher.
Adrian Perez
Comment 4 2017-10-10 13:22:37 PDT
First I am going to take care of the rest of bugs which are preventing usage of the new GLib-based API, and then I will post the patch for this one ;-) Thanks for the comments supporting the removal — I was aware of the agreement, but I wanted to make sure it would not go completely unannounced.
Adrian Perez
Comment 5 2017-10-10 16:03:34 PDT
Created attachment 323357 [details] Patch
WebKit Commit Bot
Comment 6 2017-10-10 18:01:57 PDT
Comment on attachment 323357 [details] Patch Clearing flags on attachment: 323357 Committed r223162: <http://trac.webkit.org/changeset/223162>
WebKit Commit Bot
Comment 7 2017-10-10 18:01:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.