Bug 17810

Summary:

FloatConverison.h uses CG types (when using CG), possibly without CG header

Product:

WebKit

Reporter:

Mark Mentovai <mark>

Component:

Platform

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
#include CGBase.h to get CoreGraphics type definitions	darin: review+

Mark Mentovai

Reported 2008-03-12 14:38:14 PDT

During a non-injected header build, FloatConversion.h can reference CoreGraphics types (when PLATFORM(CG) is true) without including any CoreGraphics headers.

Attachments
#include CGBase.h to get CoreGraphics type definitions (828 bytes, patch) 2008-03-12 14:40 PDT, Mark Mentovai	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Mentovai

Comment 1 2008-03-12 14:40:12 PDT

Created attachment 19715 [details] #include CGBase.h to get CoreGraphics type definitions

Darin Adler

Comment 2 2008-03-13 10:09:45 PDT

Comment on attachment 19715 [details] #include CGBase.h to get CoreGraphics type definitions Looks fine, r=me

Eric Seidel (no email)

Comment 3 2008-03-13 20:45:45 PDT

Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053

Note You need to log in before you can comment on or make changes to this bug.