Bug 178086

Summary:

Fix the Windows build after r223031

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebCore Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jlewis3, rniwa, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Wenson Hsieh

Reported 2017-10-09 10:03:36 PDT

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\page\EventHandler.cpp(2285): error C2440: 'return': cannot convert from 'initializer list' to 'WebCore::EventHandler::DragTargetResponse' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\page\EventHandler.cpp(2285): note: No constructor could take the source type, or constructor overload resolution was ambiguous

Attachments
Patch (1.36 KB, patch) 2017-10-09 10:11 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-10-09 10:11:25 PDT

Created attachment 323184 [details] Patch

Wenson Hsieh

Comment 2 2017-10-09 10:22:58 PDT

Hmm, the patch stuck in the Win EWS queue behind 11 other commits :/ Going to just land this now as a speculative fix. Hopefully it addresses the build failure...

Wenson Hsieh

Comment 3 2017-10-09 12:33:08 PDT

Fixed by r223050 and r223054.

Note You need to log in before you can comment on or make changes to this bug.