Bug 178081

Summary: [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, commit-queue, dino, fred.wang, lforschler, mcatanzaro, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=175125
Attachments:
Description Flags
Patch none

Description Adrian Perez 2017-10-09 08:16:23 PDT
Similarly to what was done for bug #175125, we should use the
value of the “Cflags” field from “epoxy.pc”. In most cases it
will be empty, but the correct thing is respecting it.

Example: changes like https://github.com/anholt/libepoxy/pull/113
may result in the “Cflags” field being populated, and it's better
to make WebKit pick its value that being bitten by build failures
in the future and/or in less desktop-y platforms.
Comment 1 Adrian Perez 2017-10-09 08:21:09 PDT
Created attachment 323175 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-09 09:04:43 PDT
Comment on attachment 323175 [details]
Patch

Clearing flags on attachment: 323175

Committed r223045: <http://trac.webkit.org/changeset/223045>
Comment 3 WebKit Commit Bot 2017-10-09 09:04:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-10-09 09:05:19 PDT
<rdar://problem/34886578>