Bug 178079

Summary: [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Severity: Normal CC: calvaris, cgarcia, commit-queue, eocanha, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Xabier Rodríguez Calvar 2017-10-09 04:54:33 PDT
[GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
Comment 1 Xabier Rodríguez Calvar 2017-10-09 05:01:01 PDT
Created attachment 323169 [details]
Comment 2 Zan Dobersek 2017-10-10 03:53:57 PDT
Comment on attachment 323169 [details]

r=me if Quique approves.
Comment 3 Enrique Ocaña 2017-10-10 05:42:40 PDT
Comment on attachment 323169 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=323169&action=review

> Source/WebCore/ChangeLog:11
> +        downloadbuffer element to seek bejond the file size, which causes

"beyond" O:-)

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:381
> +        priv->seekable = FALSE;

This change makes sense when webKitWebSrcStop() is called from https://github.com/WebKit/webkit/blob/f0e46ed/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp#L743 , but I was worried about what would happen when it's called from any of the other places which legitimate want to stop the element because of an error. However, after cheching all those places, they either can only happen before seeking is even possible (initial access control check, invalid url, change to GST_STATE_READY) or because of recoverable seek errors. Therefore there's no danger in this change and I support it.
Comment 4 Xabier Rodríguez Calvar 2017-10-10 22:09:24 PDT
Created attachment 323385 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-10-10 22:48:51 PDT
Comment on attachment 323385 [details]
Patch for landing

Clearing flags on attachment: 323385

Committed r223168: <http://trac.webkit.org/changeset/223168>
Comment 6 WebKit Commit Bot 2017-10-10 22:48:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-10 22:50:05 PDT