| Summary: | [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, cgarcia, commit-queue, eocanha, webkit-bug-importer, zan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Xabier Rodríguez Calvar
2017-10-09 04:54:33 PDT
Created attachment 323169 [details]
Patch
Comment on attachment 323169 [details]
Patch
r=me if Quique approves.
Comment on attachment 323169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323169&action=review > Source/WebCore/ChangeLog:11 > + downloadbuffer element to seek bejond the file size, which causes "beyond" O:-) > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:381 > + priv->seekable = FALSE; This change makes sense when webKitWebSrcStop() is called from https://github.com/WebKit/webkit/blob/f0e46ed/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp#L743 , but I was worried about what would happen when it's called from any of the other places which legitimate want to stop the element because of an error. However, after cheching all those places, they either can only happen before seeking is even possible (initial access control check, invalid url, change to GST_STATE_READY) or because of recoverable seek errors. Therefore there's no danger in this change and I support it. Created attachment 323385 [details]
Patch for landing
Comment on attachment 323385 [details] Patch for landing Clearing flags on attachment: 323385 Committed r223168: <http://trac.webkit.org/changeset/223168> All reviewed patches have been landed. Closing bug. |