Bug 17805

Summary: Can't build FastMalloc.cpp in certain non-pch non-AllInOneFile configurations
Product: WebKit Reporter: Mark Mentovai <mark>
Component: JavaScriptCoreAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 17493    
Attachments:
Description Flags
Move #include eric: review+

Mark Mentovai
Reported 2008-03-12 13:54:52 PDT
FastMalloc.cpp has an #include that can, in certain configurations, occur within "namespace WTF". This is incorrect. The #include should be moved so that it never occurs within an unexpected scope.
Attachments
Move #include (991 bytes, patch)
2008-03-12 13:57 PDT, Mark Mentovai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Mentovai
Comment 1 2008-03-12 13:57:07 PDT
Created attachment 19709 [details] Move #include The existing #include occurs within #if defined(WTF_CHANGES) && PLATFORM(DARWIN). I selected the new location to also occur within preprocessor source that's active in the same case.
Eric Seidel (no email)
Comment 2 2008-03-12 14:22:41 PDT
Comment on attachment 19709 [details] Move #include Yup. Include was clearly wrong. This looks fine. Again, very surprised this would be failing in your compile environment and not ours. r=me.
Eric Seidel (no email)
Comment 3 2008-03-13 20:45:45 PDT
Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053
Note You need to log in before you can comment on or make changes to this bug.