Bug 178046

Summary:

Web Inspector: make items in the CanvasOverviewContentView more flexible

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

175485

Attachments:

Description	Flags
Patch	bburg: review-
[Image] After Patch is applied	none
[Image] Before	none

Devin Rousso

Reported 2017-10-07 00:16:07 PDT

Since we are using a flex box, we should take advantage of the flexibility available and make the items grow to fit the space available. This should have an added benefit of providing more space for the preview, allowing it to be larger.

Attachments
Patch (1.59 KB, patch) 2017-10-07 00:16 PDT, Devin Rousso	bburg: review-	Details Formatted Diff Diff
[Image] After Patch is applied (325.87 KB, image/png) 2017-10-07 00:17 PDT, Devin Rousso	no flags	Details
[Image] Before (85.61 KB, image/png) 2017-10-07 15:58 PDT, Devin Rousso	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-10-07 00:16:50 PDT

Created attachment 323088 [details] Patch

Devin Rousso

Comment 2 2017-10-07 00:17:03 PDT

Created attachment 323089 [details] [Image] After Patch is applied

Joseph Pecoraro

Comment 3 2017-10-07 02:07:07 PDT

Again there needs to be a before picture, ideally with the exact same content and window size, to really understand what is changing.

Devin Rousso

Comment 4 2017-10-07 15:58:51 PDT

Created attachment 323103 [details] [Image] Before

Joseph Pecoraro

Comment 5 2017-10-08 14:15:14 PDT

I actually like the Before picture better. The extra padding around the sides makes the contents stand out more.

Blaze Burg

Comment 6 2017-10-09 11:35:02 PDT

Comment on attachment 323088 [details] Patch I prefer the second one, as the first one just looks kind of cramped with the tiny gray border. Joe, can we land this and revert if it is too annoying or space wasting?

Blaze Burg

Comment 7 2017-10-09 11:53:40 PDT

Oops, I misread which attachment is which. I agree with Joe now. :P

Blaze Burg

Comment 8 2017-10-09 11:54:10 PDT

I suppose we could still force a gutter on both sides and use flex box for the rest of the content area..

Devin Rousso

Comment 9 2017-10-23 21:57:28 PDT

I think the consensus is to leave it as is. I've gotten used to it as well :P

Note You need to log in before you can comment on or make changes to this bug.