Summary: | Make the names of the options consistent | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Robin Morisset
2017-10-05 05:43:52 PDT
Created attachment 322833 [details]
Patch
Comment on attachment 322833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322833&action=review r=me with comments and when you fix the build > Source/JavaScriptCore/ChangeLog:3 > + Rename verboseDFGByteCodeParsing in verboseDFGBytecodeParsing This should be the bugzilla bug name The prepare ChangeLog script takes a “-b” option that’ll fill this out for you > Source/WebCore/ChangeLog:3 > + Fix typos in comments This should be the bugzilla name Created attachment 322861 [details]
Fixed
Comment on attachment 322861 [details]
Fixed
r=me still
FYI for future patches, you don't need to ask for a review again if I r+ before with some comments.
Comment on attachment 322861 [details]
Fixed
Putting it in the co;;it queue.
Comment on attachment 322861 [details] Fixed Clearing flags on attachment: 322861 Committed r223047: <http://trac.webkit.org/changeset/223047> All reviewed patches have been landed. Closing bug. |