Bug 177933

Summary: Make the names of the options consistent
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixed none

Robin Morisset
Reported 2017-10-05 05:43:52 PDT
Currently, some options to JSC use the ByteCode spelling, while others use the Bytecode spelling. I will make all of them take the Bytecode spelling, and keep some alias with the old spelling for backwards compatibility.
Attachments
Patch (50.80 KB, patch)
2017-10-05 06:41 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Fixed (56.49 KB, patch)
2017-10-05 11:07 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2017-10-05 06:41:20 PDT
Created attachment 322833 [details] Patch
Saam Barati
Comment 2 2017-10-05 09:06:43 PDT
Comment on attachment 322833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322833&action=review r=me with comments and when you fix the build > Source/JavaScriptCore/ChangeLog:3 > + Rename verboseDFGByteCodeParsing in verboseDFGBytecodeParsing This should be the bugzilla bug name The prepare ChangeLog script takes a “-b” option that’ll fill this out for you > Source/WebCore/ChangeLog:3 > + Fix typos in comments This should be the bugzilla name
Robin Morisset
Comment 3 2017-10-05 11:07:26 PDT
Created attachment 322861 [details] Fixed
Saam Barati
Comment 4 2017-10-08 17:47:56 PDT
Comment on attachment 322861 [details] Fixed r=me still FYI for future patches, you don't need to ask for a review again if I r+ before with some comments.
Robin Morisset
Comment 5 2017-10-09 09:21:58 PDT
Comment on attachment 322861 [details] Fixed Putting it in the co;;it queue.
WebKit Commit Bot
Comment 6 2017-10-09 09:49:18 PDT
Comment on attachment 322861 [details] Fixed Clearing flags on attachment: 322861 Committed r223047: <http://trac.webkit.org/changeset/223047>
WebKit Commit Bot
Comment 7 2017-10-09 09:49:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-10-09 09:50:31 PDT
<rdar://problem/34887358>
Note You need to log in before you can comment on or make changes to this bug.