Bug 177880
| Summary: | 3 poly-proto JSC tests timing out on debug after r222827 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fpizlo, jlewis3, saam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Haddad
The following tests are timing out on Debug JSC bots after http://trac.webkit.org/changeset/222827
microbenchmarks/poly-proto-access.js.ftl-no-cjit-small-pool
typeProfiler.yaml/typeProfiler/deltablue-for-of.js.ftl-type-profiler-force-poly-proto-ftl-eager
typeProfiler.yaml/typeProfiler/getter-richards.js.ftl-type-profiler-force-poly-proto-ftl-eager
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/36
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
I'll look into this.
Saam Barati
landed a change to make the tests run for less time in:
https://trac.webkit.org/changeset/222866/webkit
Radar WebKit Bug Importer
<rdar://problem/34817122>
Ryan Haddad
(In reply to Saam Barati from comment #2)
> landed a change to make the tests run for less time in:
> https://trac.webkit.org/changeset/222866/webkit
These two tests are still timing out after this change:
typeProfiler.yaml/typeProfiler/deltablue-for-of.js.ftl-type-profiler-force-poly-proto-ftl-eager
typeProfiler.yaml/typeProfiler/getter-richards.js.ftl-type-profiler-force-poly-proto-ftl-eager
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/42
Saam Barati
Looking into it
Saam Barati
second attempt at fix landed in:
https://trac.webkit.org/changeset/222914/webkit
Ryan Haddad
These tests are still timing out:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/45
Saam Barati
Let me try to make them run for even less time.
Saam Barati
(In reply to Saam Barati from comment #8)
> Let me try to make them run for even less time.
ok, hopefully third time is the charm:
https://trac.webkit.org/changeset/223037/webkit
Ryan Haddad
(In reply to Saam Barati from comment #9)
> (In reply to Saam Barati from comment #8)
> > Let me try to make them run for even less time.
>
> ok, hopefully third time is the charm:
> https://trac.webkit.org/changeset/223037/webkit
No luck :(
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/1338
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/122
Saam Barati
(In reply to Ryan Haddad from comment #10)
> (In reply to Saam Barati from comment #9)
> > (In reply to Saam Barati from comment #8)
> > > Let me try to make them run for even less time.
> >
> > ok, hopefully third time is the charm:
> > https://trac.webkit.org/changeset/223037/webkit
> No luck :(
>
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/1338
>
> https://build.webkit.org/builders/Apple%20High%20Sierra%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/122
Ok. I'm going to skip these tests on debug.
Saam Barati
skipped in:
https://trac.webkit.org/changeset/223056/webkit