Bug 177880

Summary: 3 poly-proto JSC tests timing out on debug after r222827
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Saam Barati <sbarati>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jlewis3, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ryan Haddad 2017-10-04 10:09:15 PDT
The following tests are timing out on Debug JSC bots after http://trac.webkit.org/changeset/222827

microbenchmarks/poly-proto-access.js.ftl-no-cjit-small-pool
typeProfiler.yaml/typeProfiler/deltablue-for-of.js.ftl-type-profiler-force-poly-proto-ftl-eager
typeProfiler.yaml/typeProfiler/getter-richards.js.ftl-type-profiler-force-poly-proto-ftl-eager

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/36
Comment 1 Saam Barati 2017-10-04 11:44:44 PDT
I'll look into this.
Comment 2 Saam Barati 2017-10-04 11:57:02 PDT
landed a change to make the tests run for less time in:
https://trac.webkit.org/changeset/222866/webkit
Comment 3 Radar WebKit Bug Importer 2017-10-04 11:58:57 PDT
<rdar://problem/34817122>
Comment 4 Ryan Haddad 2017-10-05 09:43:50 PDT
(In reply to Saam Barati from comment #2)
> landed a change to make the tests run for less time in:
> https://trac.webkit.org/changeset/222866/webkit

These two tests are still timing out after this change:
typeProfiler.yaml/typeProfiler/deltablue-for-of.js.ftl-type-profiler-force-poly-proto-ftl-eager
typeProfiler.yaml/typeProfiler/getter-richards.js.ftl-type-profiler-force-poly-proto-ftl-eager

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/42
Comment 5 Saam Barati 2017-10-05 10:00:07 PDT
Looking into it
Comment 6 Saam Barati 2017-10-05 10:18:56 PDT
second attempt at fix landed in:
https://trac.webkit.org/changeset/222914/webkit
Comment 7 Ryan Haddad 2017-10-06 09:07:17 PDT
These tests are still timing out:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/45
Comment 8 Saam Barati 2017-10-08 17:41:29 PDT
Let me try to make them run for even less time.
Comment 9 Saam Barati 2017-10-08 17:45:15 PDT
(In reply to Saam Barati from comment #8)
> Let me try to make them run for even less time.

ok, hopefully third time is the charm:
https://trac.webkit.org/changeset/223037/webkit
Comment 10 Ryan Haddad 2017-10-09 09:42:32 PDT
(In reply to Saam Barati from comment #9)
> (In reply to Saam Barati from comment #8)
> > Let me try to make them run for even less time.
> 
> ok, hopefully third time is the charm:
> https://trac.webkit.org/changeset/223037/webkit
No luck :(

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/1338

https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/122
Comment 11 Saam Barati 2017-10-09 11:31:43 PDT
(In reply to Ryan Haddad from comment #10)
> (In reply to Saam Barati from comment #9)
> > (In reply to Saam Barati from comment #8)
> > > Let me try to make them run for even less time.
> > 
> > ok, hopefully third time is the charm:
> > https://trac.webkit.org/changeset/223037/webkit
> No luck :(
> 
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/1338
> 
> https://build.webkit.org/builders/Apple%20High%20Sierra%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/122

Ok. I'm going to skip these tests on debug.
Comment 12 Saam Barati 2017-10-09 11:37:33 PDT
skipped in:
https://trac.webkit.org/changeset/223056/webkit