Bug 17788

Summary: CookieJarWin must be split
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Split the cookies aroben: review+

Brent Fulgham
Reported 2008-03-11 16:50:28 PDT
In a land where #if/#endif macros are frowned upon, the CookieJarWin.cpp must surely be purged from our archive as EVERY SINGLE METHOD is conditionalized.
Attachments
Split the cookies (15.67 KB, patch)
2008-03-11 17:09 PDT, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2008-03-11 17:09:18 PDT
Created attachment 19688 [details] Split the cookies Split the cookie jar into: * CookieJarCFNetWin.cpp: CFNetwork-specific cookie handling. * CookieJarWin.cpp: INet-ish cookie handling.
Adam Roben (:aroben)
Comment 2 2008-03-11 17:12:41 PDT
Comment on attachment 19688 [details] Split the cookies r=me!
Matt Lilek
Comment 3 2008-03-11 17:34:51 PDT
Landed in r30974.
Note You need to log in before you can comment on or make changes to this bug.