Summary: | [GTK][WPE] GIFImageDecoder never clears decoded frames even when told to do so | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Miguel Gomez <magomez> | ||||||||||
Component: | WebKitGTK | Assignee: | Miguel Gomez <magomez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, cgarcia, commit-queue | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Miguel Gomez
2017-10-04 04:11:27 PDT
Created attachment 322809 [details]
Patch
Attachment 322809 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 322809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322809&action=review > Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:110 > + for (size_t i = frameIndex; i > 0; i--) { we normally do --i in for loops. > Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:128 > + const GIFFrameContext* frameContext = m_reader->frameContext(i - 1); const auto*. This can return nullptr, if we know for sure we should never get nullptr in this particular case, then add an assert, otherwise, handle the null case here, I guess continuing the loop. > Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:133 > + if (frameRect.contains(IntRect(IntPoint(), size()))) I think you can do something like if (frameRect.contains({ { }, size() } }))) > Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:149 > + size_t startFrame = findFirstRequiredFrameToDecode(index); > + for (size_t i = startFrame; i <= index; i++) This could probably be a single line for (auto i = findFirstRequiredFrameToDecode(index); i <= index; ++i) > Source/WebCore/platform/image-decoders/gif/GIFImageReader.h:289 > + return frame < m_frames.size() ? m_frames[frame].get() : 0; 0 -> nullptr Comment on attachment 322809 [details] Patch Attachment 322809 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4765738 New failing tests: workers/wasm-long-compile.html Created attachment 322813 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 322809 [details] Patch Attachment 322809 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4765781 New failing tests: accessibility/ios-simulator/video-elements-ios.html Created attachment 322818 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 322823 [details]
Patch
Attachment 322823 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 322823 [details] Patch Clearing flags on attachment: 322823 Committed r222910: <http://trac.webkit.org/changeset/222910> All reviewed patches have been landed. Closing bug. |