Bug 177860

Summary: [GTK] GtkUtilities.h should not be included in libs not linked to GTK
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-10-04 03:06:52 PDT
HyphenationLibHyphen must not depend on GtkUtilities.h, since HyphenationLibHyphen is not built as part of the WebCorePlatformGTK static lib that is linked to GTK+, it's built as part of the WebCore static lib which is not.
Attachments
Patch (7.01 KB, patch)
2017-10-04 04:30 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-10-04 04:28:43 PDT
Also as of yesterday, we're using it in FontCacheFreeType.cpp, which is not good because that's not built as part of WebCorePlatformGTK.
Michael Catanzaro
Comment 2 2017-10-04 04:30:36 PDT
Created attachment 322651 [details] Patch
WebKit Commit Bot
Comment 3 2017-10-04 07:07:22 PDT
Comment on attachment 322651 [details] Patch Clearing flags on attachment: 322651 Committed r222844: <http://trac.webkit.org/changeset/222844>
WebKit Commit Bot
Comment 4 2017-10-04 07:07:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.