Bug 177830

Summary:

Move scroll snap point unregistration from willBeRemovedFromTree to willBeDestroyed

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2017-10-03 12:13:44 PDT

willBeRemovedFromTree is called conditionally, relying on unregistering objects in there is highly error prone.

Comment 1 Radar WebKit Bug Importer 2017-10-03 12:16:02 PDT

<rdar://problem/34796065>

Comment 2 Radar WebKit Bug Importer 2017-10-03 12:18:04 PDT

<rdar://problem/34796100>

Comment 3 zalan 2017-10-03 12:18:34 PDT

Created attachment 322560 [details]
Patch

Comment 4 WebKit Commit Bot 2017-10-03 16:09:08 PDT

The commit-queue encountered the following flaky tests while processing attachment 322560 [details]:

The commit-queue is continuing to process your patch.

Comment 5 WebKit Commit Bot 2017-10-03 16:09:09 PDT

The commit-queue encountered the following flaky tests while processing attachment 322560 [details]:

The commit-queue is continuing to process your patch.

Comment 6 WebKit Commit Bot 2017-10-03 17:13:37 PDT

Comment on attachment 322560 [details]
Patch

Clearing flags on attachment: 322560

Committed r222823: <http://trac.webkit.org/changeset/222823>

Comment 7 WebKit Commit Bot 2017-10-03 17:13:38 PDT

All reviewed patches have been landed.  Closing bug.