Bug 177789

Summary: WeakPtr should have a move constructor
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, koivisto, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+, ggaren: commit-queue+
Patch
none
Patch none

Geoffrey Garen
Reported 2017-10-02 15:26:48 PDT
WeakPtr should have a move constructor
Attachments
Patch (1.34 KB, patch)
2017-10-02 15:27 PDT, Geoffrey Garen 		zalan: review+
ggaren: commit-queue+
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2017-10-02 15:59 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2017-10-02 16:54 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2017-10-02 15:27:37 PDT
Created attachment 322457 [details] Patch
alan
Comment 2 2017-10-02 15:43:19 PDT
Comment on attachment 322457 [details] Patch ofc
Chris Dumez
Comment 3 2017-10-02 15:52:39 PDT
Comment on attachment 322457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322457&action=review > Source/WTF/wtf/WeakPtr.h:77 > + WeakPtr& operator=(const WeakPtr&) = default; No WeakPtr& operator=(const WeakPtr&&) = default; ?
Chris Dumez
Comment 4 2017-10-02 15:53:21 PDT
Comment on attachment 322457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322457&action=review > Source/WTF/wtf/WeakPtr.h:70 > WeakPtr(const WeakPtr& o) : m_ref(o.m_ref) { } Can this one be = default; as well?
Geoffrey Garen
Comment 5 2017-10-02 15:59:42 PDT
Created attachment 322464 [details] Patch
Chris Dumez
Comment 6 2017-10-02 16:02:25 PDT
Comment on attachment 322464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322464&action=review I think that if we just drop the custom copy constructor / assignment operator then we'd get implicit move constructor / assignment operators, no? > Source/WTF/wtf/WeakPtr.h:77 > + WeakPtr& operator=(const WeakPtr&) = default; Why don't we want the WeakPtr& operator=(const WeakPtr&&) = default; too?
Chris Dumez
Comment 7 2017-10-02 16:03:27 PDT
Comment on attachment 322464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322464&action=review > Source/WTF/ChangeLog:3 > + WeakPtr should have a move constructor It would be good to API-test this change.
Geoffrey Garen
Comment 8 2017-10-02 16:54:48 PDT
Created attachment 322473 [details] Patch
Chris Dumez
Comment 9 2017-10-02 16:57:37 PDT
Comment on attachment 322473 [details] Patch r=me
WebKit Commit Bot
Comment 10 2017-10-02 17:42:09 PDT
Comment on attachment 322473 [details] Patch Clearing flags on attachment: 322473 Committed r222764: <http://trac.webkit.org/changeset/222764>
WebKit Commit Bot
Comment 11 2017-10-02 17:42:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-10-02 17:43:18 PDT
<rdar://problem/34781637>
Note You need to log in before you can comment on or make changes to this bug.