Bug 177768 – Upgrade Brotli to version 1.0.1 and WOFF2 to latest upstream

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

Upgrade Brotli to version 1.0.1 and WOFF2 to latest upstream

[Frédéric Wang (:fredw)]

Created attachment 322417 [details]
Patch

[Build Bot]

Attachment 322417 [details] did not pass style-queue:


ERROR: Unexpected diff format when parsing a chunk: "liftT19:viceandydebt>RSSpoolneckblowT16:doorevalT17:letsfailoralpollnovacolsgene \xe2\x80\x94softrometillross<h3>pourfadepink<tr>mini)|!(minezh:\xe8barshear00);milk -->ironfreddiskwentsoilputs/js/holyT22:ISBNT20:adamsees<h2>json', 'contT21: RSSloopasiamoon</p>soulLINEfortcartT14:<h1>80px!--<9px;T04:mike:46ZniceinchYorkricezh:\xe4'));puremageparatonebond:37Z_of_']);000,zh:\xe7tankyardbowlbush:56ZJava30px"
ERROR: Unexpected diff format when parsing a chunk: 's:// [];tollplug(){'
ERROR: Unexpected diff format when parsing a chunk: '201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037201320122011201020092008200720062005200420032002200120001999199819971996199519941993199219911990198919881987198619851984198319821981198019791978197719761975197419731972197119701969196819671966196519641963196219611960195919581957195619551954195319521951195010001024139400009999comom\xc3\xa1sesteestaperotodohacecadaa\xc3\xb1obiend\xc3\xadaas\xc3\xadvidacasootroforosolootracualdijosidograntipotemadebealgoqu\xc3\xa9estonadatrespococasabajotodasinoaguapuesunosantediceluisellamayozonaamorpisoobraclicellodioshoracasi\xd0\xb7\xd0\xb0\xd0\xbd\xd0\xb0\xd0\xbe\xd0\xbc\xd1\x80\xd0\xb0\xd1\x80\xd1\x83\xd1\x82\xd0\xb0\xd0\xbd\xd0\xb5\xd0\xbf\xd0\xbe\xd0\xbe\xd1\x82\xd0\xb8\xd0\xb7\xd0\xbd\xd0\xbe\xd0\xb4\xd0\xbe\xd1\x82\xd0\xbe\xd0\xb6\xd0\xb5\xd0\xbe\xd0\xbd\xd0\xb8\xd1\x85\xd0\x9d\xd0\xb0\xd0\xb5\xd0\xb5\xd0\xb1\xd1\x8b\xd0\xbc\xd1\x8b\xd0\x92\xd1\x8b\xd1\x81\xd0\xbe\xd0\xb2\xd1\x8b\xd0\xb2\xd0\xbe\xd0\x9d\xd0\xbe\xd0\xbe\xd0\xb1\xd0\x9f\xd0\xbe\xd0\xbb\xd0\xb8\xd0\xbd\xd0\xb8\xd0\xa0\xd0\xa4\xd0\x9d\xd0\xb5\xd0\x9c\xd1\x8b\xd1\x82\xd1\x8b\xd0\x9e\xd0\xbd\xd0\xb8\xd0\xbc\xd0\xb4\xd0\xb0\xd0\x97\xd0\xb0\xd0\x94\xd0\xb0\xd0\x9d\xd1\x83\xd0\x9e\xd0\xb1\xd1\x82\xd0\xb5\xd0\x98\xd0\xb7\xd0\xb5\xd0\xb9\xd0\xbd\xd1\x83\xd0\xbc\xd0\xbc\xd0\xa2\xd1\x8b\xd1\x83\xd0\xb6\xd9\x81\xd9\x8a\xd8\xa3\xd9\x86\xd9\x85\xd8\xa7\xd9\x85\xd8\xb9\xd9\x83\xd9\x84\xd8\xa3\xd9\x88\xd8\xb1\xd8\xaf\xd9\x8a\xd8\xa7\xd9\x81\xd9\x89\xd9\x87\xd9\x88\xd9\x84\xd9\x85\xd9\x84\xd9\x83\xd8\xa7\xd9\x88\xd9\x84\xd9\x87\xd8\xa8\xd8\xb3\xd8\xa7\xd9\x84\xd8\xa5\xd9\x86\xd9\x87\xd9\x8a\xd8\xa3\xd9\x8a\xd9\x82\xd8\xaf\xd9\x87\xd9\x84\xd8\xab\xd9\x85\xd8\xa8\xd9\x87\xd9\x84\xd9\x88\xd9\x84\xd9\x8a\xd8\xa8\xd9\x84\xd8\xa7\xd9\x8a\xd8\xa8\xd9\x83\xd8\xb4\xd9\x8a\xd8\xa7\xd9\x85\xd8\xa3\xd9\x85\xd9\x86\xd8\xaa\xd8\xa8\xd9\x8a\xd9\x84\xd9\x86\xd8\xad\xd8\xa8\xd9\x87\xd9\x85\xd9\x85\xd8\xb4\xd9\x88\xd8\xb4firstvideolightworldmediawhitecloseblackrightsmallbooksplacemusicfieldorderpointvalueleveltableboardhousegroupworksyearsstatetodaywaterstartstyledeathpowerphonenighterrorinputabouttermstitletoolseventlocaltimeslargewordsgamesshortspacefocusclearmodelblockguideradiosharewomenagainmoneyimagenamesyounglineslatercolorgreenfront&amp;watchforcepricerulesbeginaftervisitissueareasbelowindextotalhourslabelprintpressbuiltlinksspeedstudytradefoundsenseundershownformsrangeaddedstillmovedtakenaboveflashfixedoftenotherviewschecklegalriveritemsquickshapehumanexistgoingmoviethirdbasicpeacestagewidthloginideaswrotepagesusersdrivestorebreaksouthvoicesitesmonthwherebuildwhichearthforumthreesportpartyClicklowerlivesclasslayerentrystoryusagesoundcourtyour birthpopuptypesapplyImagebeinguppernoteseveryshowsmeansextramatchtrackknownearlybegansuperpapernorthlearngivennamedendedTermspartsGroupbrandusingwomanfalsereadyaudiotakeswhile.com/livedcasesdailychildgreatjudgethoseunitsneverbroadcoastcoverapplefilescyclesceneplansclickwritequeenpieceemailframeolderphotolimitcachecivilscaleenterthemetheretouchboundroyalaskedwholesincestock namefaithheartemptyofferscopeownedmightalbumthinkbloodarraymajortrustcanonunioncountvalidstoneStyleLoginhappyoccurleft:freshquitefilmsgradeneedsurbanfightbasishoverauto;route.htmlmixedfinalYour slidetopicbrownalonedrawnsplitreachRightdatesmarchquotegoodsLinksdoubtasyncthumballowchiefyouthnovel10px;serveuntilhandsCheckSpacequeryjamesequaltwice0,000Startpanelsongsroundeightshiftworthpostsleadsweeksavoidthesemilesplanesmartalphaplantmarksratesplaysclaimsalestextsstarswrong</h3>thing.org/multiheardPowerstandtokensolid(thisbringshipsstafftriedcallsfullyfactsagentThis //-->adminegyptEvent15px;Emailtrue"crossspentblogsbox">notedleavechinasizesguest</h4>robotheavytrue,sevengrandcrimesignsawaredancephase><!--en_US&#39;200px_namelatinenjoyajax.ationsmithU.S. holdspeterindianav">chainscorecomesdoingpriorShare1990sromanlistsjapanfallstrialowneragree</h2>abusealertopera"-//WcardshillsteamsPhototruthclean.php?saintmetallouismeantproofbriefrow">genretrucklooksValueFrame.net/-->'
ERROR: Unexpected diff format when parsing a chunk: 'using '
ERROR: Unexpected diff format when parsing a chunk: '\x0e\x0f\x0f\x0e'
ERROR: Unexpected diff format when parsing a chunk: '\x0c\x0b'
ERROR: Unexpected diff format when parsing a chunk: "/index.phparrival of-jssdk'));managed toincompletecasualtiescompletionChristiansSeptember arithmeticproceduresmight haveProductionit appearsPhilosophyfriendshipleading togiving thetoward theguaranteeddocumentedcolor:#000video gamecommissionreflectingchange theassociatedsans-serifonkeypress; padding:He was theunderlyingtypically , and the srcElementsuccessivesince the should be networkingaccountinguse of thelower thanshows that</span>"
ERROR: Unexpected diff format when parsing a chunk: '<script>(fturned outhaving the</span>'
ERROR: Unexpected diff format when parsing a chunk: 'said to havein the firstwhile othershypotheticalphilosopherspower of thecontained inperformed byinability towere writtenspan style="input name="the questionintended forrejection ofimplies thatinvented thethe standardwas probablylink betweenprofessor ofinteractionschanging theIndian Ocean class="lastworking with\'http://www.years beforeThis was therecreationalentering themeasurementsan extremelyvalue of thestart of the'
ERROR: Unexpected diff format when parsing a chunk: 'if and only ifregions of theleading to therelations withUnited Nationsstyle="height:other than theype" content="Association of'
ERROR: Unexpected diff format when parsing a chunk: '\xce\x95\xce\xbb\xce\xbb\xce\xb7\xce\xbd\xce\xb9\xce\xba\xce\xac'
ERROR: Source/ThirdParty/ChangeLog:38:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Frédéric Wang (:fredw)]

Created attachment 322496 [details]
Patch

[Michael Catanzaro]

Comment on attachment 322496 [details]
Patch

r- for the reason we just discussed in person

[Frédéric Wang (:fredw)]

Created attachment 322507 [details]
Patch

OK, I did not have the include errors in my local build because I had the brotli headers installed on my system. Hopefully, this version is correct now.

[Frédéric Wang (:fredw)]

(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 322496 [details]
> Patch
> 
> r- for the reason we just discussed in person

So for the record, we opened https://github.com/google/woff2/issues/89 ; If Google is open to change the license of WOFF2 then we can just do that change in the present bug ; and then consider the follow-up bug 177804 and bug 177862. Otherwise, we will just have to remove the code and disable WOFF2 support.

[Frédéric Wang (:fredw)]

Committed r222903: <http://trac.webkit.org/changeset/222903>