| Summary: | Use of uninitialized value $targetIdlFile in hash element at preprocess-idls.pl line 165. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||||||
| Component: | Bindings | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, cgarcia, commit-queue, darin, Hironori.Fujii, mcatanzaro, svillar, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | Other | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Michael Catanzaro
2017-10-02 06:54:13 PDT
Summoning lovers slash understanders slash victims of Perl, known or suspected .... Modules/webvr/GamepadWebVR.idl supplements Modules/gamepad/Gamepad.idl. But, Gamepad.idl is not processed because ENABLE_GAMEPAD is OFF. Created attachment 325121 [details]
Patch
Attachment 325121 [details] did not pass style-queue:
ERROR: Source/WebCore/CMakeLists.txt:998: There should be exactly one empty line instead of 0 between "Modules/gamepad/NavigatorGamepad.idl" and "Modules/webvr/GamepadWebVR.idl". [list/emptyline] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325123 [details]
Patch
Created attachment 325146 [details]
Patch
Comment on attachment 325146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325146&action=review > Source/WebCore/Sources.txt:2978 > +Modules/webvr/GamepadWebVR.cpp There should be a blank line between files in different directories. > Source/WebCore/bindings/scripts/preprocess-idls.pl:164 > + my $targetIdlFile = $interfaceNameToIdlFile{$baseFile} or die "${baseFile}.idl is not found which is supplemented by $idlFile"; How about "${baseFile}.idl not found, but it is supplemented by $idlFile" Also: thanks ;) Created attachment 325311 [details]
Patch
* Addressed review feedbacks.
Comment on attachment 325311 [details] Patch Clearing flags on attachment: 325311 Committed r224168: <https://trac.webkit.org/changeset/224168> All reviewed patches have been landed. Closing bug. |