Summary: | Inspector should support point-and-click to select a node to inspect | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Matt Lilek <dev+webkit> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Enhancement | CC: | dev+webkit, jl, rik, timothy | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||
OS: | All | ||||||||||||||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2008-03-11 09:36:57 PDT
*** Bug 19322 has been marked as a duplicate of this bug. *** Created attachment 23456 [details]
Initial cut
As I wrote in the ChangeLog:
Despite putting this up for review, I'm not intending to land it as is. Among the known issues:
- Need better art for the magnifying glass button
- Is EventHandler really the best place for intercepting the node click - feels dirty. Would
making -[WebView setHoverFeedbackSuspended:] cross-platform be a better route?
- I think I can get away with not having to track searchingForNode in ElementsPanel
- Some method names could be tweaked.
Hrm....git diff didn't include the button png.... Created attachment 23549 [details]
round 2
This isn't much different from the previous version, but is more landable - ie: uses localizedStrings and also fixes a couple of bugs like stopping the search when you switch panels, but still does have a few bugs.
Created attachment 23550 [details]
button
Comment on attachment 23549 [details]
round 2
+ InspectorController* inspector = m_page->inspectorController();
+ if (!inspector)
+ return;
+ inspector->mouseDidMoveOverElement(result, modifierFlags);
Better written as:
if (InspectorController* inspector = m_page->inspectorController())
inspector->mouseDidMoveOverElement(result, modifierFlags);
+ InspectorController* controller = reinterpret_cast<InspectorController*>(JSObjectGetPrivate(thisObject));
+ if (controller)
+ controller->toggleSearchForNodeInPage();
Better written as:
if (InspectorController* controller = reinterpret_cast<InspectorController*>(JSObjectGetPrivate(thisObject)))
controller->toggleSearchForNodeInPage();
Created attachment 23551 [details]
Better button
Created attachment 23552 [details]
Even better button
Created attachment 23553 [details]
with suggestions
Comment on attachment 23553 [details]
with suggestions
broke something, hang on
Created attachment 23583 [details]
round 3
Fixes the bugs with toggle behavior and includes Tim's version of the button
Created attachment 23584 [details]
round 3
I know how to read and click on the right file, honest
Committed revision 36685. |