Bug 177696

Summary: Remove redundant RenderObject::selectionRoot and dependencies
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177678    
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2017-09-29 18:23:10 PDT
There's only one selection root.
Attachments
Patch (7.29 KB, patch)
2017-09-29 18:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.27 KB, patch)
2017-09-29 19:44 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-09-29 18:25:49 PDT
Created attachment 322262 [details] Patch
Ryosuke Niwa
Comment 2 2017-09-29 18:58:06 PDT
Comment on attachment 322262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322262&action=review > Source/WebCore/rendering/RenderView.h:96 > + void selectionStartEnd(unsigned& start, unsigned& end) const { selectionData().selectionStartEndPositions(start, end); } Can we rename this to getSelectionStartEnd?
alan
Comment 3 2017-09-29 19:44:23 PDT
Created attachment 322267 [details] Patch
WebKit Commit Bot
Comment 4 2017-09-29 21:31:33 PDT
Comment on attachment 322267 [details] Patch Clearing flags on attachment: 322267 Committed r222677: <http://trac.webkit.org/changeset/222677>
WebKit Commit Bot
Comment 5 2017-09-29 21:31:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-29 21:32:38 PDT
<rdar://problem/34753244>
Darin Adler
Comment 7 2017-09-30 16:50:14 PDT
Comment on attachment 322262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322262&action=review >> Source/WebCore/rendering/RenderView.h:96 >> + void selectionStartEnd(unsigned& start, unsigned& end) const { selectionData().selectionStartEndPositions(start, end); } > > Can we rename this to getSelectionStartEnd? Or have it return a structure with both start and end rather than using two out arguments?
Note You need to log in before you can comment on or make changes to this bug.