Summary: | Remove ENABLE_CSS_REGIONS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
Component: | CSS | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, commit-queue, darin, mcatanzaro, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Michael Catanzaro
2017-09-29 16:21:10 PDT
Created attachment 322253 [details]
Patch
(In reply to Michael Catanzaro from comment #0) > Remove ENABLE_CSS_REGIONS. > > Also, for GTK, deprecate webkit_dom_element_get_webkit_region_overset. This > is no problem because the API was added automatically and it's likely that > zero applications are using it. Also, the API has never done anything, since GTK has never enabled ENABLE_CSS_REGIONS. I forgot how much fun autogenerated API was! Hmmm I didn't notice the GObject property, we need to decide how to handle that. Created attachment 322318 [details]
Patch
Comment on attachment 322318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322318&action=review > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:325 > + g_warning("%s: CSS Regions support has been removed, this function does nothing.", __func__); This says "does nothing". > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:249 > + g_warning("%s: CSS Regions support has been removed, the webkit-region-overset property no longer works.", __func__); This says "no longer works". I think I like "does nothing" better. The problem is a property never does anything, it just exists, so the "does nothing" text doesn't work as well there. Comment on attachment 322318 [details] Patch Clearing flags on attachment: 322318 Committed r222704: <http://trac.webkit.org/changeset/222704> All reviewed patches have been landed. Closing bug. |