Bug 177689

Summary: Remove ENABLE_CSS_REGIONS
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: CSSAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, darin, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2017-09-29 16:21:10 PDT
Remove ENABLE_CSS_REGIONS. Also, for GTK, deprecate webkit_dom_element_get_webkit_region_overset. This is no problem because the API was added automatically and it's likely that zero applications are using it.
Attachments
Patch (21.33 KB, patch)
2017-09-29 16:32 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (22.39 KB, patch)
2017-10-01 07:15 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-09-29 16:32:37 PDT
Created attachment 322253 [details] Patch
Michael Catanzaro
Comment 2 2017-09-29 16:34:46 PDT
(In reply to Michael Catanzaro from comment #0) > Remove ENABLE_CSS_REGIONS. > > Also, for GTK, deprecate webkit_dom_element_get_webkit_region_overset. This > is no problem because the API was added automatically and it's likely that > zero applications are using it. Also, the API has never done anything, since GTK has never enabled ENABLE_CSS_REGIONS. I forgot how much fun autogenerated API was!
Michael Catanzaro
Comment 3 2017-09-29 17:03:02 PDT
Hmmm I didn't notice the GObject property, we need to decide how to handle that.
Michael Catanzaro
Comment 4 2017-10-01 07:15:55 PDT
Created attachment 322318 [details] Patch
Darin Adler
Comment 5 2017-10-01 13:46:21 PDT
Comment on attachment 322318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322318&action=review > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:325 > + g_warning("%s: CSS Regions support has been removed, this function does nothing.", __func__); This says "does nothing". > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:249 > + g_warning("%s: CSS Regions support has been removed, the webkit-region-overset property no longer works.", __func__); This says "no longer works". I think I like "does nothing" better.
Michael Catanzaro
Comment 6 2017-10-02 04:38:48 PDT
The problem is a property never does anything, it just exists, so the "does nothing" text doesn't work as well there.
WebKit Commit Bot
Comment 7 2017-10-02 05:06:00 PDT
Comment on attachment 322318 [details] Patch Clearing flags on attachment: 322318 Committed r222704: <http://trac.webkit.org/changeset/222704>
WebKit Commit Bot
Comment 8 2017-10-02 05:06:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-10-02 05:06:58 PDT
<rdar://problem/34765572>
Note You need to log in before you can comment on or make changes to this bug.