Bug 177685

Summary: Remove SelectionSubtreeRoot::RenderSubtreesMap
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177678    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2017-09-29 14:58:34 PDT
This is part of the selection root cleanup.
Attachments
Patch (15.67 KB, patch)
2017-09-29 15:01 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.63 KB, patch)
2017-09-29 15:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.71 KB, patch)
2017-09-29 15:10 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-09-29 15:01:56 PDT
Created attachment 322239 [details] Patch
Andy Estes
Comment 2 2017-09-29 15:04:34 PDT
Comment on attachment 322239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322239&action=review > Source/WebCore/rendering/RenderView.cpp:815 > + std::unique_ptr<OldSelectionData> oldSelectionData = std::make_unique<OldSelectionData>(); I'd use auto here.
alan
Comment 3 2017-09-29 15:08:56 PDT
Created attachment 322240 [details] Patch
alan
Comment 4 2017-09-29 15:10:47 PDT
Created attachment 322242 [details] Patch
WebKit Commit Bot
Comment 5 2017-09-29 15:50:59 PDT
Comment on attachment 322242 [details] Patch Clearing flags on attachment: 322242 Committed r222669: <http://trac.webkit.org/changeset/222669>
WebKit Commit Bot
Comment 6 2017-09-29 15:51:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-29 15:52:09 PDT
<rdar://problem/34749485>
Note You need to log in before you can comment on or make changes to this bug.