Bug 177677 – SelectionRangeData should not hold raw RenderObject pointers

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia.

[Radar WebKit Bug Importer]

<rdar://problem/34763060>

[zalan]

Created attachment 322378 [details]
Patch

[zalan]

Created attachment 322380 [details]
Patch

[Sam Weinig]

Comment on attachment 322380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322380&action=review

> Source/WebCore/ChangeLog:9
> +        Not testable.

I think adding why its not testable would be helpful.

Also an explanation of the change and the reason behind it would be great.

> Source/WebCore/rendering/SelectionRangeData.h:80
> +    RenderObject* start() const { return m_selectionContext.start(); }
> +    RenderObject* end() const { return m_selectionContext.end(); }

Do the callers of these functions always null check?

[zalan]

Created attachment 322400 [details]
Patch

[Antti Koivisto]

Comment on attachment 322400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322400&action=review

> Source/WebCore/rendering/SelectionRangeData.h:51
> +            : m_start(start ? makeWeakPtr(*start) : nullptr)

Might be useful to add a makeWeakPtr variant that takes a pointer and deals with nullptr.

[WebKit Commit Bot]

Comment on attachment 322400 [details]
Patch

Clearing flags on attachment: 322400

Committed r222738: <http://trac.webkit.org/changeset/222738>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.