Bug 177676

Summary: Web Inspector: Styles: Undo reverts all changes at once
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 193223    
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
hi: review+
[Video] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2017-09-29 12:27:42 PDT
Created attachment 322219 [details] [Animated GIF] Bug Steps: 1. Inspect any element with 2+ CSS properties. 2. Modify both property values one after another. 3. Move focus away from CSS editing field (CodeMirror). 4. Press Command-Z. Expected: Only the last change is reverted. Actual: All changes are reverted. Notes: I reproduced it in the shipped Safari and ToT WebKit.
Attachments
[Animated GIF] Bug (115.95 KB, image/gif)
2017-09-29 12:27 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.91 KB, patch)
2019-01-07 16:36 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
[Video] With patch applied (1.99 MB, video/quicktime)
2019-01-07 16:40 PST, Nikita Vasilyev 		no flags
Details
Patch (2.91 KB, patch)
2019-01-08 18:52 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-09-29 12:28:06 PDT
<rdar://problem/34745031>
Nikita Vasilyev
Comment 2 2019-01-07 16:36:01 PST
Created attachment 358553 [details] Patch
Nikita Vasilyev
Comment 3 2019-01-07 16:40:32 PST
Created attachment 358556 [details] [Video] With patch applied
Devin Rousso
Comment 4 2019-01-08 18:33:04 PST
Comment on attachment 358553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358553&action=review r=me, wow I didn't realize how much I wanted this till I tried using it 😅 > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:375 > + spreadsheetTextFieldDidBlur(textField, event, hasChanged) This is already implicitly past tense given the function name. I think `changed` is fine enough (it's also past tense).
Nikita Vasilyev
Comment 5 2019-01-08 18:52:00 PST
Created attachment 358661 [details] Patch
WebKit Commit Bot
Comment 6 2019-01-08 19:29:27 PST
Comment on attachment 358661 [details] Patch Clearing flags on attachment: 358661 Committed r239762: <https://trac.webkit.org/changeset/239762>
WebKit Commit Bot
Comment 7 2019-01-08 19:29:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.