| Summary: | Add WKWebViewConfiguration SPI equivalent to WKPageConfigurationSetBackgroundCPULimit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ggaren, mitz, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2017-09-28 22:32:23 PDT
Created attachment 322168 [details]
Patch
Comment on attachment 322168 [details]
Patch
r=me
I wonder what our strategy is for which things are interfaces on Configuration and which are interfaces on ProcessPool. To some extent, CPU limit is a property of a process.
If we do something on a ProcessPool we've done it wrong and we should move it to be organized per Page/WKWebView. Comment on attachment 322168 [details]
Patch
This patch seems wrong. It adds an ivar to WKWebViewConfiguration but doesn’t update -copyWithZone: to copy the value of that ivar.
> If we do something on a ProcessPool we've done it wrong and we should move
> it to be organized per Page/WKWebView.
I don't understand the rationale here.
WKProcessPoolPrivate.h is 97 lines long. Are all 97 lines wrong?
I'll update the ivar stuff in another patch. A lot of WKProcessPoolPrivate is wrong. _setCookieAcceptPolicy and _cookieStoragePartitioningEnabled should be associated with a WebsiteDataStore, not a ProcessPool. _setAllowsSpecificHTTPSCertificate should be associated with a WKWebView, not a ProcessPool. Downloads are per-NSURLSession, which should be per-WebsiteDataStore, but right now they're ProcessPool global. etc. Reopening to attach new patch. Created attachment 322232 [details]
Patch
|