Bug 177644

Summary: Add WKWebViewConfiguration SPI equivalent to WKPageConfigurationSetBackgroundCPULimit
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-09-28 22:32:23 PDT
Add WKWebViewConfiguration SPI equivalent to WKPageConfigurationSetBackgroundCPULimit
Attachments
Patch (4.08 KB, patch)
2017-09-28 22:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.30 KB, patch)
2017-09-29 14:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-28 22:33:49 PDT
Created attachment 322168 [details] Patch
Geoffrey Garen
Comment 2 2017-09-29 11:09:01 PDT
Comment on attachment 322168 [details] Patch r=me I wonder what our strategy is for which things are interfaces on Configuration and which are interfaces on ProcessPool. To some extent, CPU limit is a property of a process.
Alex Christensen
Comment 3 2017-09-29 13:49:08 PDT
If we do something on a ProcessPool we've done it wrong and we should move it to be organized per Page/WKWebView.
Alex Christensen
Comment 4 2017-09-29 13:50:26 PDT
http://trac.webkit.org/r222663
Radar WebKit Bug Importer
Comment 5 2017-09-29 13:50:58 PDT
<rdar://problem/34746705>
mitz
Comment 6 2017-09-29 13:53:40 PDT
Comment on attachment 322168 [details] Patch This patch seems wrong. It adds an ivar to WKWebViewConfiguration but doesn’t update -copyWithZone: to copy the value of that ivar.
Geoffrey Garen
Comment 7 2017-09-29 14:10:23 PDT
> If we do something on a ProcessPool we've done it wrong and we should move > it to be organized per Page/WKWebView. I don't understand the rationale here. WKProcessPoolPrivate.h is 97 lines long. Are all 97 lines wrong?
Alex Christensen
Comment 8 2017-09-29 14:15:07 PDT
I'll update the ivar stuff in another patch. A lot of WKProcessPoolPrivate is wrong. _setCookieAcceptPolicy and _cookieStoragePartitioningEnabled should be associated with a WebsiteDataStore, not a ProcessPool. _setAllowsSpecificHTTPSCertificate should be associated with a WKWebView, not a ProcessPool. Downloads are per-NSURLSession, which should be per-WebsiteDataStore, but right now they're ProcessPool global. etc.
Alex Christensen
Comment 9 2017-09-29 14:28:39 PDT
Reopening to attach new patch.
Alex Christensen
Comment 10 2017-09-29 14:28:40 PDT
Created attachment 322232 [details] Patch
Alex Christensen
Comment 11 2017-09-29 14:36:20 PDT
http://trac.webkit.org/r222666
Note You need to log in before you can comment on or make changes to this bug.