Bug 177636

Summary: Clean up Long Press Selection Tests
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Megan Gardner
Reported 2017-09-28 18:59:51 PDT
Clean up Long Press Selection Tests
Attachments
Patch (43.71 KB, patch)
2017-09-28 19:08 PDT, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2017-09-28 19:08:00 PDT
Created attachment 322155 [details] Patch
Tim Horton
Comment 2 2017-09-28 19:13:49 PDT
Comment on attachment 322155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322155&action=review > LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:22 > + var pressPointX = firstTargetRect.x + firstTargetRect.width/2; Spaces around operators! Always! :) > LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:95 > - <meta name="viewport" content="initial-scale=1"> > + <meta name="viewport" content="initial-scale=1.0"> This was better before IMO > LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:59 > + testRunner.runUIScript(touchAndDragFromPointToPoint(dragX2,dragY,dragX,dragY), function(result) { Spaces after commas too!
Megan Gardner
Comment 3 2017-10-02 18:03:56 PDT
https://trac.webkit.org/changeset/222643/webkit
Radar WebKit Bug Importer
Comment 4 2017-10-02 18:04:21 PDT
<rdar://problem/34782026>
Note You need to log in before you can comment on or make changes to this bug.