Bug 177557

Summary:

Rename "FlowThread" to "FragmentedFlow"

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	zalan: review+

Dave Hyatt

Reported 2017-09-27 11:51:37 PDT

Rename "FlowThread" to "FragmentedFlow"

Attachments
Patch (578.36 KB, patch) 2017-09-27 11:52 PDT, Dave Hyatt	zalan: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (611.46 KB, application/zip) 2017-09-27 12:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.33 MB, application/zip) 2017-09-27 12:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (796.61 KB, application/zip) 2017-09-27 12:47 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (532.07 KB, application/zip) 2017-09-27 13:03 PDT, Build Bot	no flags	Details
Patch (579.89 KB, patch) 2017-09-27 13:09 PDT, Dave Hyatt	zalan: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2017-09-27 11:52:44 PDT

Created attachment 321986 [details] Patch

Build Bot

Comment 2 2017-09-27 11:55:26 PDT

Attachment 321986 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:250: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderMultiColumnFlow.cpp:451: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:53: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayer.cpp:89: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderingAllInOne.cpp:66: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderMultiColumnFlow.h:138: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/rendering/RenderMultiColumnFlow.h:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-09-27 12:41:32 PDT

Comment on attachment 321986 [details] Patch Attachment 321986 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4678854 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-09-27 12:41:34 PDT

Created attachment 322000 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-09-27 12:42:03 PDT

Comment on attachment 321986 [details] Patch Attachment 321986 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4678731 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-09-27 12:42:04 PDT

Created attachment 322001 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-09-27 12:47:17 PDT

Comment on attachment 321986 [details] Patch Attachment 321986 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4678932 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-09-27 12:47:19 PDT

Created attachment 322003 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-09-27 13:03:58 PDT

Comment on attachment 321986 [details] Patch Attachment 321986 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4678992 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-09-27 13:03:59 PDT

Created attachment 322006 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Dave Hyatt

Comment 11 2017-09-27 13:09:48 PDT

Created attachment 322009 [details] Patch

Dave Hyatt

Comment 12 2017-09-27 13:54:30 PDT

Landed in r222575.

Note You need to log in before you can comment on or make changes to this bug.