Bug 177549

Summary: Have PingLoad take a CompletionHandler
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-09-27 10:33:54 PDT 
Have PingLoad take a CompletionHandler instead of relying on it calling on method on the NetworkConnectionToWebProcess when it is done.
Comment 1 Chris Dumez 2017-09-27 10:34:42 PDT 
Created attachment 321972 [details]
Patch
Comment 2 youenn fablet 2017-09-27 10:57:36 PDT 
Comment on attachment 321972 [details]
Patch

LGTM modulo bots
Comment 3 Chris Dumez 2017-09-27 11:00:40 PDT 
Created attachment 321975 [details]
Patch
Comment 4 Chris Dumez 2017-09-27 11:23:07 PDT 
Created attachment 321979 [details]
Patch
Comment 5 Chris Dumez 2017-09-27 11:25:45 PDT 
Created attachment 321980 [details]
Patch
Comment 6 Chris Dumez 2017-09-27 11:31:22 PDT 
Created attachment 321981 [details]
Patch
Comment 7 WebKit Commit Bot 2017-09-27 13:01:29 PDT 
Comment on attachment 321981 [details]
Patch

Clearing flags on attachment: 321981

Committed r222570: <http://trac.webkit.org/changeset/222570>
Comment 8 WebKit Commit Bot 2017-09-27 13:01:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-27 13:34:56 PDT 
<rdar://problem/34695511>