Bug 177549

Summary: Have PingLoad take a CompletionHandler
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-09-27 10:33:54 PDT
Have PingLoad take a CompletionHandler instead of relying on it calling on method on the NetworkConnectionToWebProcess when it is done.
Attachments
Patch (6.10 KB, patch)
2017-09-27 10:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2017-09-27 11:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2017-09-27 11:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.64 KB, patch)
2017-09-27 11:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.58 KB, patch)
2017-09-27 11:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-09-27 10:34:42 PDT
Created attachment 321972 [details] Patch
youenn fablet
Comment 2 2017-09-27 10:57:36 PDT
Comment on attachment 321972 [details] Patch LGTM modulo bots
Chris Dumez
Comment 3 2017-09-27 11:00:40 PDT
Created attachment 321975 [details] Patch
Chris Dumez
Comment 4 2017-09-27 11:23:07 PDT
Created attachment 321979 [details] Patch
Chris Dumez
Comment 5 2017-09-27 11:25:45 PDT
Created attachment 321980 [details] Patch
Chris Dumez
Comment 6 2017-09-27 11:31:22 PDT
Created attachment 321981 [details] Patch
WebKit Commit Bot
Comment 7 2017-09-27 13:01:29 PDT
Comment on attachment 321981 [details] Patch Clearing flags on attachment: 321981 Committed r222570: <http://trac.webkit.org/changeset/222570>
WebKit Commit Bot
Comment 8 2017-09-27 13:01:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-09-27 13:34:56 PDT
<rdar://problem/34695511>
Note You need to log in before you can comment on or make changes to this bug.