Bug 177546
| Summary: | [GTK] macOS-specific files missing from released tarballs, breaking the build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | yan12125 <3cmqut5e44sxaake> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Mac | ||
| OS: | macOS 10.12 | ||
yan12125
I'm trying to build WebKitGTK+ 2.18.0 on macOS Sierra. The process is blocked by a missing file:
/opt/local/var/macports/build/_Users_yen_Projects_macports-ports_www_webkit2-gtk/webkit2-gtk/work/webkitgtk-2.18.0/Source/WTF/wtf/threads/Signals.cpp:33:10: fatal error: 'MachExceptionsServer.h' file not found
#include "MachExceptionsServer.h"
^~~~~~~~~~~~~~~~~~~~~~~~
Seems this header is generated by [1]. However, this cmake file is missing from the release tarball at [2] and apparently it's excluded explicitly [3]. Could them be added back? Thanks for any feedback.
[1] https://github.com/WebKit/webkit/blob/e0d741c/Source/WTF/wtf/PlatformMac.cmake#L50
[2] https://webkitgtk.org/releases/webkitgtk-2.18.0.tar.xz
[3] https://trac.webkit.org/browser/webkit/trunk/Tools/gtk/manifest.txt.in?rev=%20219486, line 7 and 46
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
yan12125
The original issue is fixed after https://github.com/WebKit/webkit/commit/ebd290d9fba427a15c6fd8227e022fbc72cc8765. Thanks for the work!
Radar WebKit Bug Importer
<rdar://problem/41621764>