Bug 177542

Summary: AX: [ATK] object:state-changed notifications missing for multiple ARIA attributes
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Bug Depends on: 177634    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Joanmarie Diggs 2017-09-27 08:47:00 PDT
When the following ARIA attributes have value changes, an object:state-changed notification is expected but currently not emitted:

* aria-disabled
* aria-expanded
* aria-pressed
* aria-readonly
* aria-required
Comment 1 Radar WebKit Bug Importer 2017-09-27 08:47:27 PDT
<rdar://problem/34686677>
Comment 2 Joanmarie Diggs 2017-09-27 11:43:41 PDT
Created attachment 321985 [details]
Patch
Comment 3 Joanmarie Diggs 2017-09-27 13:58:13 PDT
Comment on attachment 321985 [details]
Patch

Chris: Please review. Thanks!
Comment 4 chris fleizach 2017-09-28 15:03:24 PDT
Comment on attachment 321985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321985&action=review

> Source/WebCore/accessibility/AXObjectCache.h:288
> +        AXPressedChanged,

Can we call this PressedState (it seems similar to DisabledState)

> Source/WebCore/accessibility/AXObjectCache.h:289
> +        AXReadOnlyChanged,

ReadOnlyStatus

> Source/WebCore/accessibility/AXObjectCache.h:290
> +        AXRequiredChanged,

RequiredStatus
Comment 5 Joanmarie Diggs 2017-09-28 15:42:45 PDT
Created attachment 322130 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-28 17:13:17 PDT
Comment on attachment 322130 [details]
Patch

Clearing flags on attachment: 322130

Committed r222640: <http://trac.webkit.org/changeset/222640>
Comment 7 WebKit Commit Bot 2017-09-28 17:13:18 PDT
All reviewed patches have been landed.  Closing bug.