Bug 177509

Summary: Pass a completion handler instead of a WebFramePolicyListenerProxy during policy decisions
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: REOPENED ---    
Severity: Normal CC: buildbot, commit-queue, rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239546
Bug Depends on: 177580    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Description Alex Christensen 2017-09-26 14:31:50 PDT
Pass a completion handler instead of a WebFramePolicyListenerProxy during policy decisions
Comment 1 Alex Christensen 2017-09-26 14:36:55 PDT
Created attachment 321874 [details]
Patch
Comment 2 Build Bot 2017-09-26 16:39:54 PDT
Comment on attachment 321874 [details]
Patch

Attachment 321874 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4669223

New failing tests:
fast/dom/HTMLAnchorElement/anchor-file-blob-download.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html
http/tests/download/anchor-download-redirect.html
http/tests/download/anchor-download-no-extension.html
fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html
fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html
http/tests/download/anchor-download-no-value.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html
fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
fast/dom/HTMLAnchorElement/anchor-download.html
http/tests/security/anchor-download-allow-blob.html
http/tests/download/area-download.html
http/tests/download/anchor-download-attribute-content-disposition.html
http/tests/security/anchor-download-allow-sameorigin.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html
Comment 3 Build Bot 2017-09-26 16:39:55 PDT
Created attachment 321890 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Alex Christensen 2017-09-26 17:18:22 PDT
Created attachment 321901 [details]
Patch
Comment 5 Alex Christensen 2017-09-26 17:26:34 PDT
Created attachment 321903 [details]
Patch
Comment 6 Alex Christensen 2017-09-26 17:33:36 PDT
Created attachment 321906 [details]
Patch
Comment 7 Alex Christensen 2017-09-26 17:49:31 PDT
Created attachment 321910 [details]
Patch
Comment 8 Alex Christensen 2017-09-26 18:39:19 PDT
http://trac.webkit.org/r222541
Comment 9 Radar WebKit Bug Importer 2017-09-27 12:15:15 PDT
<rdar://problem/34692870>
Comment 10 WebKit Commit Bot 2017-09-27 16:21:17 PDT
Re-opened since this is blocked by bug 177580