Bug 177509

Summary:

Pass a completion handler instead of a WebFramePolicyListenerProxy during policy decisions

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

REOPENED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=239546

Bug Depends on:

177580

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none
Patch	thorton: review+

Alex Christensen

Reported 2017-09-26 14:31:50 PDT

Pass a completion handler instead of a WebFramePolicyListenerProxy during policy decisions

Attachments
Patch (69.68 KB, patch) 2017-09-26 14:36 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.84 MB, application/zip) 2017-09-26 16:39 PDT, Build Bot	no flags	Details
Patch (69.47 KB, patch) 2017-09-26 17:18 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (69.91 KB, patch) 2017-09-26 17:26 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (69.81 KB, patch) 2017-09-26 17:33 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (70.26 KB, patch) 2017-09-26 17:49 PDT, Alex Christensen	thorton: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-09-26 14:36:55 PDT

Created attachment 321874 [details] Patch

Build Bot

Comment 2 2017-09-26 16:39:54 PDT

Comment on attachment 321874 [details] Patch Attachment 321874 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4669223 New failing tests: fast/dom/HTMLAnchorElement/anchor-file-blob-download.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html http/tests/download/anchor-download-redirect.html http/tests/download/anchor-download-no-extension.html fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html http/tests/download/anchor-download-no-value.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html fast/dom/HTMLAnchorElement/anchor-nodownload-set.html fast/dom/HTMLAnchorElement/anchor-download.html http/tests/security/anchor-download-allow-blob.html http/tests/download/area-download.html http/tests/download/anchor-download-attribute-content-disposition.html http/tests/security/anchor-download-allow-sameorigin.html fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html

Build Bot

Comment 3 2017-09-26 16:39:55 PDT

Created attachment 321890 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Alex Christensen

Comment 4 2017-09-26 17:18:22 PDT

Created attachment 321901 [details] Patch

Alex Christensen

Comment 5 2017-09-26 17:26:34 PDT

Created attachment 321903 [details] Patch

Alex Christensen

Comment 6 2017-09-26 17:33:36 PDT

Created attachment 321906 [details] Patch

Alex Christensen

Comment 7 2017-09-26 17:49:31 PDT

Created attachment 321910 [details] Patch