Bug 177506

Summary:

Rename "Region" to "Fragment"

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	zalan: review+

Dave Hyatt

Reported 2017-09-26 14:20:03 PDT

Rename "Region" to "Fragment"

Attachments
Patch (638.08 KB, text/plain) 2017-09-26 14:21 PDT, Dave Hyatt	no flags	Details
Patch (421.04 KB, patch) 2017-09-26 14:22 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (422.55 KB, patch) 2017-09-26 14:34 PDT, Dave Hyatt	zalan: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2017-09-26 14:21:11 PDT

Created attachment 321869 [details] Patch

Dave Hyatt

Comment 2 2017-09-26 14:22:31 PDT

Created attachment 321871 [details] Patch

Build Bot

Comment 3 2017-09-26 14:25:17 PDT

Attachment 321871 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:871: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Element.cpp:83: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:60: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayer.cpp:99: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderFlowThread.cpp:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderingAllInOne.cpp:101: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlock.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBox.cpp:63: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1837: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderMultiColumnSet.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 14 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 4 2017-09-26 14:34:37 PDT

Created attachment 321873 [details] Patch

Build Bot

Comment 5 2017-09-26 14:35:54 PDT

Attachment 321873 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1837: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 6 2017-09-27 09:19:25 PDT

Landed in r222556.

Note You need to log in before you can comment on or make changes to this bug.