Bug 177487

Summary:

cssFloat missing in CSSPropertyDeclaration.prototype

Product:

WebKit

Reporter:

Rick Byers <rbyers>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, dean_johnson, ggaren, mjs, rniwa, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-cssfloat

Bug Depends on:

177515

Bug Blocks:

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	none

Rick Byers

Reported 2017-09-26 08:20:54 PDT

'cssFloat' in CSSStyleDeclaration.prototype is true in all engines except WebKit (tested WebKit nightly at r222497) Specified here: https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface The property exists in WebKit, it's just completely hidden from enumeration: 'cssFloat' in document.body.style > true Object.getOwnPropertyNames(document.body.style).indexOf('cssFloat') > -1 Object.getOwnPropertyNames(Object.getPrototypeOf(document.body.style)).indexOf('cssFloat') > -1

Attachments
WIP Patch (69.87 KB, patch) 2017-09-26 16:14 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (72.11 KB, patch) 2017-09-26 16:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (14.34 KB, patch) 2017-09-26 19:58 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Rick Byers

Comment 1 2017-09-26 08:23:59 PDT

It's not listed in CSSStyleDeclaration.idl: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/css/CSSStyleDeclaration.idl, but also apparently not added by the custom enumeration code for CSSStyleDeclaration.

Chris Dumez

Comment 2 2017-09-26 16:14:46 PDT

Created attachment 321885 [details] WIP Patch

Chris Dumez

Comment 3 2017-09-26 16:23:40 PDT

Created attachment 321887 [details] WIP Patch

Chris Dumez

Comment 4 2017-09-26 19:58:10 PDT

Created attachment 321931 [details] Patch

WebKit Commit Bot

Comment 5 2017-09-27 10:55:59 PDT

Comment on attachment 321931 [details] Patch Clearing flags on attachment: 321931 Committed r222559: <http://trac.webkit.org/changeset/222559>