Bug 177437

Summary: Add High Sierra bots to buildbot and dashboard
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryan Haddad
Reported 2017-09-25 10:13:25 PDT
Add High Sierra bots to buildbot and dashboard
Attachments
Patch (29.29 KB, patch)
2017-09-25 12:05 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.61 KB, patch)
2017-09-25 13:50 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-09-25 12:05:56 PDT
Created attachment 321715 [details] Patch
Alexey Proskuryakov
Comment 2 2017-09-25 13:04:06 PDT
Comment on attachment 321715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321715&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:170 > + "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2", "sierra-leaks"], I think that "sierra-leaks" needs to be removed too. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:411 > "builderNames": ["Apple Sierra Release (Build)", "Apple Sierra Debug (Build)", "Apple Sierra Release (32-bit Build)", "Apple Sierra LLINT CLoop (BuildAndTest)", "Apple Sierra 32-bit JSC (BuildAndTest)"] I think that some of these need to be removed (JSC, 32-bit).
Ryan Haddad
Comment 3 2017-09-25 13:12:07 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 321715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321715&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:170 > > + "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2", "sierra-leaks"], > > I think that "sierra-leaks" needs to be removed too. Thanks, I will remove this. > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:411 > > "builderNames": ["Apple Sierra Release (Build)", "Apple Sierra Debug (Build)", "Apple Sierra Release (32-bit Build)", "Apple Sierra LLINT CLoop (BuildAndTest)", "Apple Sierra 32-bit JSC (BuildAndTest)"] > > I think that some of these need to be removed (JSC, 32-bit). Ditto. Unfortunately unit tests didn't catch these errors. I'll have to file a bug for that. Thanks for the review!
Ryan Haddad
Comment 4 2017-09-25 13:50:45 PDT
Created attachment 321734 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-09-25 14:30:59 PDT
Comment on attachment 321734 [details] Patch for landing Clearing flags on attachment: 321734 Committed r222469: <http://trac.webkit.org/changeset/222469>
WebKit Commit Bot
Comment 6 2017-09-25 14:31:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:18:13 PDT
<rdar://problem/34692989>
Note You need to log in before you can comment on or make changes to this bug.