| Summary: | Add High Sierra bots to buildbot and dashboard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
| Component: | Tools / Tests | Assignee: | Ryan Haddad <ryanhaddad> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryan Haddad
2017-09-25 10:13:25 PDT
Created attachment 321715 [details]
Patch
Comment on attachment 321715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321715&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:170 > + "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2", "sierra-leaks"], I think that "sierra-leaks" needs to be removed too. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:411 > "builderNames": ["Apple Sierra Release (Build)", "Apple Sierra Debug (Build)", "Apple Sierra Release (32-bit Build)", "Apple Sierra LLINT CLoop (BuildAndTest)", "Apple Sierra 32-bit JSC (BuildAndTest)"] I think that some of these need to be removed (JSC, 32-bit). (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 321715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321715&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:170 > > + "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2", "sierra-leaks"], > > I think that "sierra-leaks" needs to be removed too. Thanks, I will remove this. > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:411 > > "builderNames": ["Apple Sierra Release (Build)", "Apple Sierra Debug (Build)", "Apple Sierra Release (32-bit Build)", "Apple Sierra LLINT CLoop (BuildAndTest)", "Apple Sierra 32-bit JSC (BuildAndTest)"] > > I think that some of these need to be removed (JSC, 32-bit). Ditto. Unfortunately unit tests didn't catch these errors. I'll have to file a bug for that. Thanks for the review! Created attachment 321734 [details]
Patch for landing
Comment on attachment 321734 [details] Patch for landing Clearing flags on attachment: 321734 Committed r222469: <http://trac.webkit.org/changeset/222469> All reviewed patches have been landed. Closing bug. |