Bug 177426

Summary: [CMake] Use implicit include directories for Clang as well
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161697
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2017-09-25 00:45:18 PDT
[CMake] Use implicit include directories for Clang as well
Comment 1 Zan Dobersek 2017-09-25 00:56:39 PDT
Created attachment 321674 [details]
Patch
Comment 2 Zan Dobersek 2017-09-26 00:05:49 PDT
Comment on attachment 321674 [details]
Patch

Clearing flags on attachment: 321674

Committed r222494: <http://trac.webkit.org/changeset/222494>
Comment 3 Zan Dobersek 2017-09-26 00:05:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Carlos Alberto Lopez Perez 2017-09-26 04:44:02 PDT
(In reply to Zan Dobersek from comment #3)
> All reviewed patches have been landed.  Closing bug.

With this is actually possible to use clang for cross-building?
Did you tested that? With Yocto?

Then I think we can close bug 161697
Comment 5 Zan Dobersek 2017-09-26 04:47:38 PDT
(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Zan Dobersek from comment #3)
> > All reviewed patches have been landed.  Closing bug.
> 
> With this is actually possible to use clang for cross-building?
> Did you tested that? With Yocto?
> 
> Then I think we can close bug 161697

Didn't test with Yocto, but it fixed build failures with the Clang-based Android NDK toolchain.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:17:12 PDT
<rdar://problem/34692944>