Bug 177414

Summary:

Make Attribute an enum class

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa, sam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none
Patch	ysuzuki: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none

Alex Christensen

Reported 2017-09-24 02:00:40 PDT

Make Attribute an enum class

Attachments
Patch (818.07 KB, patch) 2017-09-24 02:03 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (815.65 KB, patch) 2017-09-24 02:22 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.04 MB, application/zip) 2017-09-24 03:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.18 MB, application/zip) 2017-09-24 03:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.77 MB, application/zip) 2017-09-24 03:59 PDT, Build Bot	no flags	Details
Patch (837.72 KB, patch) 2017-09-25 09:44 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (837.83 KB, patch) 2017-09-25 10:00 PDT, Alex Christensen	ysuzuki: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.06 MB, application/zip) 2017-09-25 11:19 PDT, Build Bot	no flags	Details
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-09-24 02:03:46 PDT

Created attachment 321646 [details] Patch

Alex Christensen

Comment 2 2017-09-24 02:22:38 PDT

Created attachment 321647 [details] Patch

Build Bot

Comment 3 2017-09-24 03:04:57 PDT

Comment on attachment 321647 [details] Patch Attachment 321647 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/4641570 New failing tests: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.default-wasm wasm.yaml/wasm/fuzz/memory.js.wasm-slow-memory wasm.yaml/wasm/js-api/memory-grow.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/jsapi.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/grow-memory-2.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/memory-grow.js.wasm-slow-memory wasm.yaml/wasm/function-tests/load-offset.js.default-wasm wasm.yaml/wasm/js-api/test_memory.js.wasm-no-tls-context wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-slow-memory wasm.yaml/wasm/fuzz/memory.js.default-wasm wasm.yaml/wasm/function-tests/load-offset.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/test_Data.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/test_memory_constructor.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-slow-memory wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/element-data.js.wasm-eager-jettison wasm.yaml/wasm/js-api/test_memory.js.default-wasm wasm.yaml/wasm/spec-tests/jsapi.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-call-ic wasm.yaml/wasm/js-api/test_memory_constructor.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-eager-jettison wasm.yaml/wasm/js-api/memory-grow.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/context-switch.js.wasm-eager-jettison wasm.yaml/wasm/js-api/test_memory_constructor.js.wasm-eager-jettison wasm.yaml/wasm/js-api/element-data.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/test_Data.js.wasm-no-tls-context wasm.yaml/wasm/js-api/test_memory_constructor.js.wasm-slow-memory wasm.yaml/wasm/js-api/memory-grow.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-slow-memory wasm.yaml/wasm/function-tests/trap-from-start-async.js.default-wasm wasm.yaml/wasm/js-api/test_Data.js.wasm-slow-memory wasm.yaml/wasm/js-api/test_Data.js.wasm-no-call-ic wasm.yaml/wasm/fuzz/memory.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm wasm.yaml/wasm/js-api/test_Data.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/jsapi.js.default-wasm wasm.yaml/wasm/js-api/test_memory.js.wasm-eager-jettison wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-tls-context wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-tls-context wasm.yaml/wasm/js-api/element-data.js.wasm-slow-memory wasm.yaml/wasm/function-tests/grow-memory-2.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/grow-memory-2.js.wasm-no-tls-context wasm.yaml/wasm/js-api/memory-grow.js.default-wasm wasm.yaml/wasm/js-api/memory-grow.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/context-switch.js.default-wasm wasm.yaml/wasm/function-tests/context-switch.js.wasm-slow-memory wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/jsapi.js.wasm-no-call-ic wasm.yaml/wasm/js-api/test_memory_constructor.js.default-wasm wasm.yaml/wasm/js-api/test_memory_constructor.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/load-offset.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/load-offset.js.wasm-slow-memory wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/load-offset.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/grow-memory-2.js.wasm-slow-memory wasm.yaml/wasm/js-api/element-data.js.wasm-no-tls-context wasm.yaml/wasm/js-api/test_memory.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/fuzz/memory.js.wasm-eager-jettison wasm.yaml/wasm/js-api/element-data.js.default-wasm wasm.yaml/wasm/function-tests/grow-memory-2.js.default-wasm wasm.yaml/wasm/function-tests/grow-memory-2.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-call-ic wasm.yaml/wasm/js-api/test_Data.js.default-wasm wasm.yaml/wasm/spec-tests/jsapi.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-call-ic wasm.yaml/wasm/js-api/test_memory.js.wasm-slow-memory wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-call-ic wasm.yaml/wasm/js-api/test_memory.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/load-offset.js.wasm-eager-jettison wasm.yaml/wasm/js-api/element-data.js.wasm-no-call-ic

Build Bot

Comment 4 2017-09-24 03:46:19 PDT

Comment on attachment 321647 [details] Patch Attachment 321647 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4641655 New failing tests: workers/wasm-mem-post-message.html workers/wasm-hashset.html

Build Bot

Comment 5 2017-09-24 03:46:21 PDT

Created attachment 321648 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-09-24 03:52:13 PDT

Comment on attachment 321647 [details] Patch Attachment 321647 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4641660 New failing tests: workers/wasm-mem-post-message.html workers/wasm-hashset.html

Build Bot

Comment 7 2017-09-24 03:52:15 PDT

Created attachment 321649 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-09-24 03:59:07 PDT

Comment on attachment 321647 [details] Patch Attachment 321647 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4641661 New failing tests: workers/wasm-mem-post-message.html workers/wasm-hashset.html

Build Bot

Comment 9 2017-09-24 03:59:09 PDT

Created attachment 321650 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Ryosuke Niwa

Comment 10 2017-09-24 16:30:59 PDT

Comment on attachment 321647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321647&action=review > Source/JavaScriptCore/runtime/PropertySlot.h:38 > -enum Attribute : unsigned { > +enum class Attribute : unsigned { It would have called this PropertyAttribute instead. "Attribute" is a confusing term in WebCore with respect to content attribute (of elements).

Alex Christensen

Comment 11 2017-09-25 09:44:10 PDT

Created attachment 321694 [details] Patch

Alex Christensen

Comment 12 2017-09-25 10:00:49 PDT

Created attachment 321696 [details] Patch

Build Bot

Comment 13 2017-09-25 11:19:09 PDT

Comment on attachment 321696 [details] Patch Attachment 321696 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4650626 New failing tests: http/tests/security/cross-origin-xsl-BLOCKED.html

Build Bot

Comment 14 2017-09-25 11:19:11 PDT

Created attachment 321707 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Yusuke Suzuki

Comment 15 2017-09-25 13:30:21 PDT

Comment on attachment 321696 [details] Patch r=me, I like this. And OptionSet<PropertyAttribute> would be awesome once it will be implemneted.

Alex Christensen

Comment 16 2017-09-25 15:37:42 PDT

http://trac.webkit.org/r222473

Radar WebKit Bug Importer

Comment 17 2017-09-27 12:17:30 PDT

<rdar://problem/34692960>

Note You need to log in before you can comment on or make changes to this bug.