Bug 177367

Summary:

REGRESSION: When accessibility option for font-size set in preferences, line-height set with px creates enormous height divs

Product:

WebKit

Reporter:

Ben Frain <contact>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Major

CC:

cfleizach, facetothefate, mmaxfield, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Mac

OS:

macOS 10.12.4

Attachments:

Description	Flags
Safari Technology Preview 40 and Safari 11	none
Page in Safari 10	none
reproduce-html	none

Ben Frain

Reported 2017-09-22 09:39:52 PDT

Created attachment 321557 [details] Safari Technology Preview 40 and Safari 11 This issue is also present in Safari 11. When a user sets font-sizes to be displayed no less than 9px in Safari preferences and a website uses a line-height set with px values it can result in massive heights on elements. The issue can be worked around by setting line-heights with a number rather than length but it is less than ideal as many existing websites may break. I have not found it straightforward to create a reduction. However on a live site I am working with (https://www.bet365.com/?&cb=1032648335#/AA/B2/C101/D20170922/E20548296/F67258375/P10/) the issue exhibits clearly. The attachment is the page with those options set in the technology preview.

Attachments
Safari Technology Preview 40 and Safari 11 (355.44 KB, image/png) 2017-09-22 09:39 PDT, Ben Frain	no flags	Details
Page in Safari 10 (627.11 KB, image/png) 2017-09-22 09:41 PDT, Ben Frain	no flags	Details
reproduce-html (343 bytes, text/html) 2017-09-26 20:45 PDT, Zhifei Fang	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ben Frain

Comment 1 2017-09-22 09:41:43 PDT

Created attachment 321558 [details] Page in Safari 10 Comparison of same page in Safari 10

Zhifei Fang

Comment 2 2017-09-26 20:44:33 PDT

I have narrow it down. When you setting a layout with "line-height" and "font-size:0", then setting the "Never use font size smaller than" will tigger this.

Radar WebKit Bug Importer

Comment 3 2017-09-26 20:44:52 PDT

<rdar://problem/34675590>

Zhifei Fang

Comment 4 2017-09-26 20:45:40 PDT

Created attachment 321935 [details] reproduce-html

Zhifei Fang

Comment 5 2017-09-26 20:49:23 PDT

This is more like an Accessibility bug. "font-size:0" should let the Accessibility make it bigger, obviously it goes mad...

Zhifei Fang

Comment 6 2017-09-26 21:00:54 PDT

Dig a little bit more. it actually change the line-height to "179769313486231600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000px" This looks like the max value of double. Maybe Somewhere we (unsigned double) 0 - 1

Zhifei Fang

Comment 7 2017-09-27 07:34:16 PDT

Correction for my last comment, just forgot that there is no unsigned double.

Simon Fraser (smfr)

Comment 8 2017-09-28 13:41:20 PDT

Is this the same as bug 177573?

Zhifei Fang

Comment 9 2017-09-28 19:51:42 PDT

looks yes. the test is nearly same as the one I uploaded here.

Myles C. Maxfield

Comment 10 2017-10-03 12:20:51 PDT

*** This bug has been marked as a duplicate of bug 177573 ***

Note You need to log in before you can comment on or make changes to this bug.