Bug 177272

Summary:

Device iOS 11 builds fail with FileProvider linker errors

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ddkilzer, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Jonathan Bedard 2017-09-20 14:32:15 PDT

Here is an example of one of these failures:
<https://build.webkit.org/builders/Apple%20iOS%2011%20Release%20%28Build%29/builds/33/steps/compile-webkit/logs/stdio>

In short, we're linking to the Mac version of this library.  iOS should never be linking to any Mac runtime libraries, it's surprising we haven't hit this issue before.

Comment 1 Radar WebKit Bug Importer 2017-09-20 14:32:53 PDT

<rdar://problem/34557680>

Comment 2 Jonathan Bedard 2017-09-20 14:40:18 PDT

Created attachment 321375 [details]
Patch

Comment 3 David Kilzer (:ddkilzer) 2017-09-20 14:58:23 PDT

Comment on attachment 321375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321375&action=review

r=me

> Tools/WebKitTestRunner/Configurations/Base.xcconfig:93
> +FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(inherited) $(WK_PRIVATE_FRAMEWORK_STUBS_DIR)

Nit:  Semi-colon at end of line.

Comment 4 Jonathan Bedard 2017-09-20 15:08:31 PDT

Committed r222293: <http://trac.webkit.org/changeset/222293>