Bug 177271

Summary: [ios-simulator] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jlewis3, megan_gardner, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
megan_gardner: review+
Patch for landing none

Ryan Haddad
Reported 2017-09-20 14:16:50 PDT
FAIL DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:1022 Value of: [webView stringByEvaluatingJavaScript:@"output.value"] Actual: "Found data transfer item (kind: 'file', type: '') DIR: /somedirectory DIR: /somedirectory/subdirectory1 DIR: /somedirectory/subdirectory2 FILE: /somedirectory/archive.zip ('application/zip', 988 bytes) FILE: /somedirectory/icon.png ('image/png', 42130 bytes) FILE: /somedirectory/subdirectory1/text-file-1.txt ('text/plain', 43 bytes) FILE: /somedirectory/subdirectory2/text-file-2.txt ('text/plain', 44 bytes)" Expected: [expectedOutput componentsJoinedByString:@"\n"] Which is: "Found data transfer item (kind: 'string', type: 'text/plain') Found data transfer item (kind: 'file', type: '') DIR: /somedirectory DIR: /somedirectory/subdirectory1 DIR: /somedirectory/subdirectory2 FILE: /somedirectory/archive.zip ('application/zip', 988 bytes) FILE: /somedirectory/icon.png ('image/png', 42130 bytes) FILE: /somedirectory/subdirectory1/text-file-1.txt ('text/plain', 43 bytes) FILE: /somedirectory/subdirectory2/text-file-2.txt ('text/plain', 44 bytes)" https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/8
Attachments
Patch (1.62 KB, patch)
2017-09-26 08:19 PDT, Wenson Hsieh 		megan_gardner: review+
DetailsFormatted DiffDiff
Patch for landing (1.64 KB, patch)
2017-09-26 13:09 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-09-20 14:17:52 PDT
This failure started after the bots were upgraded to Xcode 9 and the iOS 11 SDK.
Ryan Haddad
Comment 2 2017-09-21 13:19:12 PDT
I can reproduce the failure when running API tests locally.
Radar WebKit Bug Importer
Comment 3 2017-09-21 16:41:39 PDT
<rdar://problem/34584653>
Wenson Hsieh
Comment 4 2017-09-26 07:57:11 PDT
I think this just needs to be rebaselined.
Wenson Hsieh
Comment 5 2017-09-26 08:19:59 PDT
Created attachment 321817 [details] Patch
Megan Gardner
Comment 6 2017-09-26 10:45:49 PDT
Comment on attachment 321817 [details] Patch Ok, so this test doesn't expect a string type anymore, because there are more things in the directory, that aren't stored as strings? Seems to make sense.
Wenson Hsieh
Comment 7 2017-09-26 13:09:17 PDT
Created attachment 321858 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-09-26 13:49:55 PDT
Comment on attachment 321858 [details] Patch for landing Clearing flags on attachment: 321858 Committed r222522: <http://trac.webkit.org/changeset/222522>
Note You need to log in before you can comment on or make changes to this bug.