Bug 177261

Summary: [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, rniwa, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Patch for landing
none
Patch for landing none

Description Jer Noble 2017-09-20 13:16:53 PDT
[Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
Comment 1 Jer Noble 2017-09-20 13:20:18 PDT
Created attachment 321349 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-09-20 13:21:09 PDT
<rdar://problem/34555743>
Comment 3 Jer Noble 2017-09-20 13:29:59 PDT
Created attachment 321352 [details]
Patch
Comment 4 Eric Carlson 2017-09-20 13:51:20 PDT
Comment on attachment 321352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321352&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:497
> +    static NeverDestroyed<String> s_keySystem("org.w3.clearkey");

static const NeverDestroyed<String> s_keySystem = MAKE_STATIC_STRING_IMPL("org.w3.clearkey");

> Source/WebCore/testing/MockCDMFactory.cpp:383
> +    static NeverDestroyed<String> s_keySystem("org.webkit.mock");

Ditto.
Comment 5 Jer Noble 2017-09-20 14:37:14 PDT
Created attachment 321374 [details]
Patch for landing
Comment 6 Jer Noble 2017-09-20 15:25:45 PDT
Created attachment 321380 [details]
Patch for landing
Comment 7 Jer Noble 2017-10-05 11:05:16 PDT
Created attachment 322859 [details]
Patch for landing
Comment 8 Build Bot 2017-10-05 13:06:53 PDT
Comment on attachment 322859 [details]
Patch for landing

Attachment 322859 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4770729

New failing tests:
fast/dom/navigator-detached-no-crash.html
Comment 9 Build Bot 2017-10-05 13:06:54 PDT
Created attachment 322889 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 10 Jer Noble 2017-10-05 14:53:51 PDT
Created attachment 322921 [details]
Patch for landing
Comment 11 Jer Noble 2017-10-05 15:58:45 PDT
Created attachment 322928 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2017-10-05 17:13:27 PDT
Comment on attachment 322928 [details]
Patch for landing

Clearing flags on attachment: 322928

Committed r222946: <http://trac.webkit.org/changeset/222946>
Comment 13 WebKit Commit Bot 2017-10-05 17:13:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Ryan Haddad 2017-10-05 22:07:52 PDT
This change caused LayoutTest fast/dom/navigator-detached-no-crash.html to fail. Rebaselined in https://trac.webkit.org/r222958