Bug 177261

Summary:

[Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, rniwa, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch for landing	none
Patch for landing	none

Jer Noble

Reported 2017-09-20 13:16:53 PDT

[Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting

Attachments
Patch (78.14 KB, patch) 2017-09-20 13:20 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (77.11 KB, patch) 2017-09-20 13:29 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (80.20 KB, patch) 2017-09-20 14:37 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (82.61 KB, patch) 2017-09-20 15:25 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (79.19 KB, patch) 2017-10-05 11:05 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.17 MB, application/zip) 2017-10-05 13:06 PDT, Build Bot	no flags	Details
Patch for landing (85.77 KB, patch) 2017-10-05 14:53 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (86.53 KB, patch) 2017-10-05 15:58 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2017-09-20 13:20:18 PDT

Created attachment 321349 [details] Patch

Radar WebKit Bug Importer

Comment 2 2017-09-20 13:21:09 PDT

<rdar://problem/34555743>

Jer Noble

Comment 3 2017-09-20 13:29:59 PDT

Created attachment 321352 [details] Patch

Eric Carlson

Comment 4 2017-09-20 13:51:20 PDT

Comment on attachment 321352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321352&action=review > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:497 > + static NeverDestroyed<String> s_keySystem("org.w3.clearkey"); static const NeverDestroyed<String> s_keySystem = MAKE_STATIC_STRING_IMPL("org.w3.clearkey"); > Source/WebCore/testing/MockCDMFactory.cpp:383 > + static NeverDestroyed<String> s_keySystem("org.webkit.mock"); Ditto.

Jer Noble

Comment 5 2017-09-20 14:37:14 PDT

Created attachment 321374 [details] Patch for landing

Jer Noble

Comment 6 2017-09-20 15:25:45 PDT

Created attachment 321380 [details] Patch for landing

Jer Noble

Comment 7 2017-10-05 11:05:16 PDT

Created attachment 322859 [details] Patch for landing

Build Bot

Comment 8 2017-10-05 13:06:53 PDT

Comment on attachment 322859 [details] Patch for landing Attachment 322859 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4770729 New failing tests: fast/dom/navigator-detached-no-crash.html

Build Bot

Comment 9 2017-10-05 13:06:54 PDT

Created attachment 322889 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Jer Noble

Comment 10 2017-10-05 14:53:51 PDT

Created attachment 322921 [details] Patch for landing

Jer Noble

Comment 11 2017-10-05 15:58:45 PDT

Created attachment 322928 [details] Patch for landing

WebKit Commit Bot

Comment 12 2017-10-05 17:13:27 PDT

Comment on attachment 322928 [details] Patch for landing Clearing flags on attachment: 322928 Committed r222946: <http://trac.webkit.org/changeset/222946>

WebKit Commit Bot

Comment 13 2017-10-05 17:13:29 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 14 2017-10-05 22:07:52 PDT

This change caused LayoutTest fast/dom/navigator-detached-no-crash.html to fail. Rebaselined in https://trac.webkit.org/r222958

Note You need to log in before you can comment on or make changes to this bug.