Summary: | [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, rniwa, ryanhaddad, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Jer Noble
2017-09-20 13:16:53 PDT
Created attachment 321349 [details]
Patch
Created attachment 321352 [details]
Patch
Comment on attachment 321352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321352&action=review > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:497 > + static NeverDestroyed<String> s_keySystem("org.w3.clearkey"); static const NeverDestroyed<String> s_keySystem = MAKE_STATIC_STRING_IMPL("org.w3.clearkey"); > Source/WebCore/testing/MockCDMFactory.cpp:383 > + static NeverDestroyed<String> s_keySystem("org.webkit.mock"); Ditto. Created attachment 321374 [details]
Patch for landing
Created attachment 321380 [details]
Patch for landing
Created attachment 322859 [details]
Patch for landing
Comment on attachment 322859 [details] Patch for landing Attachment 322859 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4770729 New failing tests: fast/dom/navigator-detached-no-crash.html Created attachment 322889 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 322921 [details]
Patch for landing
Created attachment 322928 [details]
Patch for landing
Comment on attachment 322928 [details] Patch for landing Clearing flags on attachment: 322928 Committed r222946: <http://trac.webkit.org/changeset/222946> All reviewed patches have been landed. Closing bug. This change caused LayoutTest fast/dom/navigator-detached-no-crash.html to fail. Rebaselined in https://trac.webkit.org/r222958 |