Bug 177251

Summary:

"Tag" codepoints require the complex text codepath

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, enrica, gzjjgod, hyatt, jonlee, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=177632

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	hyatt: review+

Myles C. Maxfield

Reported 2017-09-20 10:40:36 PDT

"Tag" codepoints are combining candidates

Attachments
Patch (1.67 KB, patch) 2017-09-20 10:42 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (5.27 KB, patch) 2017-09-20 12:44 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (5.38 KB, patch) 2017-09-20 12:52 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.95 MB, application/zip) 2017-09-20 13:44 PDT, Build Bot	no flags	Details
Patch (3.83 KB, patch) 2017-09-26 17:08 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (3.89 KB, patch) 2017-09-26 17:11 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.04 MB, application/zip) 2017-09-26 18:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.03 MB, application/zip) 2017-09-26 18:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.18 MB, application/zip) 2017-09-26 18:22 PDT, Build Bot	no flags	Details
Patch (5.39 KB, patch) 2017-09-26 18:35 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (5.47 KB, patch) 2017-09-26 18:40 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (3.88 KB, patch) 2017-09-27 09:41 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (3.90 KB, patch) 2017-09-27 09:43 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (3.92 KB, patch) 2017-09-27 13:53 PDT, Myles C. Maxfield	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-09-20 10:42:26 PDT

Created attachment 321332 [details] Patch

Myles C. Maxfield

Comment 2 2017-09-20 10:43:24 PDT

<rdar://problem/34384001>

Myles C. Maxfield

Comment 3 2017-09-20 12:44:11 PDT

Created attachment 321345 [details] Patch

Myles C. Maxfield

Comment 4 2017-09-20 12:52:57 PDT

Created attachment 321346 [details] Patch

Build Bot

Comment 5 2017-09-20 13:44:45 PDT

Comment on attachment 321346 [details] Patch Attachment 321346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4606744 New failing tests: fast/images/animated-gif-webkit-transform.html

Build Bot

Comment 6 2017-09-20 13:44:47 PDT

Created attachment 321356 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 7 2017-09-26 17:08:36 PDT

Created attachment 321898 [details] Patch

Myles C. Maxfield

Comment 8 2017-09-26 17:11:05 PDT

Created attachment 321899 [details] Patch

Build Bot

Comment 9 2017-09-26 18:15:22 PDT

Comment on attachment 321899 [details] Patch Attachment 321899 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4671201 New failing tests: fast/text/flag-codepoint.html

Build Bot

Comment 10 2017-09-26 18:15:24 PDT

Created attachment 321915 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-09-26 18:18:21 PDT

Comment on attachment 321899 [details] Patch Attachment 321899 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4670998 New failing tests: fast/text/flag-codepoint.html

Build Bot

Comment 12 2017-09-26 18:18:22 PDT

Created attachment 321916 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 13 2017-09-26 18:22:45 PDT

Comment on attachment 321899 [details] Patch Attachment 321899 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4671275 New failing tests: fast/text/flag-codepoint.html

Build Bot

Comment 14 2017-09-26 18:22:47 PDT

Created attachment 321918 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 15 2017-09-26 18:35:52 PDT

Created attachment 321920 [details] Patch

Myles C. Maxfield

Comment 16 2017-09-26 18:40:57 PDT

Created attachment 321922 [details] Patch

Jiang Jiang

Comment 17 2017-09-26 18:51:12 PDT

Comment on attachment 321920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321920&action=review > Source/WebCore/ChangeLog:9 > + Previously, Tag codepoints (U+E0000 - U+E007F) weren't triggering the See my comments on the tag code point ranges on radar.

Myles C. Maxfield

Comment 18 2017-09-27 09:34:06 PDT

(In reply to Jiang Jiang from comment #17) > Comment on attachment 321920 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321920&action=review > > > Source/WebCore/ChangeLog:9 > > + Previously, Tag codepoints (U+E0000 - U+E007F) weren't triggering the > > See my comments on the tag code point ranges on radar. Thanks, Jiang!

Myles C. Maxfield

Comment 19 2017-09-27 09:41:38 PDT

Created attachment 321965 [details] Patch

Myles C. Maxfield

Comment 20 2017-09-27 09:43:47 PDT

Created attachment 321967 [details] Patch

Myles C. Maxfield

Comment 21 2017-09-27 13:53:12 PDT

Created attachment 322013 [details] Patch

Dave Hyatt

Comment 22 2017-09-27 13:56:06 PDT

Comment on attachment 322013 [details] Patch r=me

Myles C. Maxfield

Comment 23 2017-09-27 14:02:51 PDT

Committed r222576: <http://trac.webkit.org/changeset/222576>

Note You need to log in before you can comment on or make changes to this bug.